From: Keiichi KII <k-keiichi@bx.jp.nec.com>
To: mpm@selenic.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [RFC][PATCH 2.6.19 take2 5/5] add "add" element in /sys/class/misc/netconsole
Date: Thu, 21 Dec 2006 19:13:49 +0900 [thread overview]
Message-ID: <458A5E5D.4020505@bx.jp.nec.com> (raw)
In-Reply-To: <458A5AAE.30209@bx.jp.nec.com>
From: Keiichi KII <k-keiichi@bx.jp.nec.com>
This patch contains the following changes.
To add port dynamically, create "add" element in /sys/class/misc/netconsole.
ex)
echo "@/eth0,@192.168.0.1/" > /sys/class/misc/netconsole/add
then the port is added with the settings sending kernel messages
to 192.168.0.1 using eth0 device.
-+- /sys/class/misc/
|-+- netconsole/
|--- add [-w-------] If you write parameter(network interface name
| or one config parameter of netconsole), The
| port related its config is added
|--- port1/
|--- port2/
...
Signed-off-by: Keiichi KII <k-keiichi@bx.jp.nec.com>
---
[changes]
1. remove unneccesary cast.
2. change config parameter for "add" element.
--- linux-2.6.19/drivers/net/netconsole.c 2006-12-21 18:39:12.719185750 +0900
+++ enhanced-netconsole/drivers/net/netconsole.c.add 2006-12-21 18:39:05.046706250 +0900
@@ -338,6 +338,30 @@ static struct miscdevice netconsole_misc
.name = "netconsole",
};
+static ssize_t store_miscdev_add(struct class_device *cdev,
+ const char *buf, size_t count)
+{
+ char *target_param;
+
+ target_param = kmalloc(count+1, GFP_KERNEL);
+ if (!target_param) {
+ printk(KERN_ERR "netconsole: kmalloc() failed!\n");
+ return -ENOMEM;
+ }
+
+ strcpy(target_param, buf);
+ if (target_param[count - 1] == '\n')
+ target_param[count - 1] = '\0';
+
+ printk(KERN_INFO "netconsole: config = [%s]\n", target_param);
+ add_target(target_param);
+ kfree(target_param);
+
+ return count;
+}
+
+static CLASS_DEVICE_ATTR(add, S_IWUSR, NULL, store_miscdev_add);
+
static struct netpoll np = {
.name = "netconsole",
.dev_name = "eth0",
@@ -467,6 +491,9 @@ static int __init init_netconsole(void)
register_console(&netconsole);
+ class_device_create_file(netconsole_miscdev.class,
+ &class_device_attr_add);
+
if(!strlen(config)) {
printk(KERN_ERR "netconsole: not configured\n");
return 0;
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: k-keiichi@bx.jp.nec.com
prev parent reply other threads:[~2006-12-21 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 9:58 [RFC][PATCH 2.6.19 take2 0/5] proposal for dynamic configurable netconsole Keiichi KII
2006-12-21 10:03 ` [RFC][PATCH 2.6.19 take2 1/5] marking __init and remove drop initialization Keiichi KII
2006-12-22 5:06 ` Matt Mackall
2006-12-21 10:09 ` [RFC][PATCH 2.6.19 take2 3/5] add interface for netconsole using sysfs Keiichi KII
2006-12-21 10:11 ` [RFC][PATCH 2.6.19 take2 4/5] switch function of netpoll Keiichi KII
2006-12-21 10:13 ` Keiichi KII [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458A5E5D.4020505@bx.jp.nec.com \
--to=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).