From: David Ahern <dsahern@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 net-next v2] iprule: support for ip_proto, sport and dport match options
Date: Tue, 6 Mar 2018 09:18:14 -0700 [thread overview]
Message-ID: <458a21cf-e11e-d4bd-3a82-3aa8ec95652c@gmail.com> (raw)
In-Reply-To: <1520274127-46640-1-git-send-email-roopa@cumulusnetworks.com>
On 3/5/18 11:22 AM, Roopa Prabhu wrote:
> diff --git a/ip/iprule.c b/ip/iprule.c
> index 6fdc9b5..a6a16e6 100644
> --- a/ip/iprule.c
> +++ b/ip/iprule.c
> @@ -45,7 +45,10 @@ static void usage(void)
> " ip rule [ list [ SELECTOR ]]\n"
> "SELECTOR := [ not ] [ from PREFIX ] [ to PREFIX ] [ tos TOS ] [ fwmark FWMARK[/MASK] ]\n"
> " [ iif STRING ] [ oif STRING ] [ pref NUMBER ] [ l3mdev ]\n"
> - " [ uidrange NUMBER-NUMBER ]\n"
> + " [ uidrange NUMBER-NUMBER ]"
> + " [ ip_proto [tcp | udp | sctp] ]"
> + " [ sport [ NUMBER | NUMBER-NUMBER ]"
> + " [ dport [ NUMBER | NUMBER-NUMBER ] ]\n"
> "ACTION := [ table TABLE_ID ]\n"
> " [ protocol PROTO ]\n"
> " [ nat ADDRESS ]\n"
missing newlines at the end of uidrange, ip_proto and sport lines; makes
the help impossible to read
next prev parent reply other threads:[~2018-03-06 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 18:22 [PATCH iproute2 net-next v2] iprule: support for ip_proto, sport and dport match options Roopa Prabhu
2018-03-06 16:18 ` David Ahern [this message]
2018-03-06 16:47 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458a21cf-e11e-d4bd-3a82-3aa8ec95652c@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).