From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f48.google.com ([209.85.160.48]:39765 "EHLO mail-pl0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785AbeCFQSV (ORCPT ); Tue, 6 Mar 2018 11:18:21 -0500 Received: by mail-pl0-f48.google.com with SMTP id s13-v6so12110711plq.6 for ; Tue, 06 Mar 2018 08:18:21 -0800 (PST) Subject: Re: [PATCH iproute2 net-next v2] iprule: support for ip_proto, sport and dport match options To: Roopa Prabhu Cc: netdev@vger.kernel.org References: <1520274127-46640-1-git-send-email-roopa@cumulusnetworks.com> From: David Ahern Message-ID: <458a21cf-e11e-d4bd-3a82-3aa8ec95652c@gmail.com> Date: Tue, 6 Mar 2018 09:18:14 -0700 MIME-Version: 1.0 In-Reply-To: <1520274127-46640-1-git-send-email-roopa@cumulusnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/5/18 11:22 AM, Roopa Prabhu wrote: > diff --git a/ip/iprule.c b/ip/iprule.c > index 6fdc9b5..a6a16e6 100644 > --- a/ip/iprule.c > +++ b/ip/iprule.c > @@ -45,7 +45,10 @@ static void usage(void) > " ip rule [ list [ SELECTOR ]]\n" > "SELECTOR := [ not ] [ from PREFIX ] [ to PREFIX ] [ tos TOS ] [ fwmark FWMARK[/MASK] ]\n" > " [ iif STRING ] [ oif STRING ] [ pref NUMBER ] [ l3mdev ]\n" > - " [ uidrange NUMBER-NUMBER ]\n" > + " [ uidrange NUMBER-NUMBER ]" > + " [ ip_proto [tcp | udp | sctp] ]" > + " [ sport [ NUMBER | NUMBER-NUMBER ]" > + " [ dport [ NUMBER | NUMBER-NUMBER ] ]\n" > "ACTION := [ table TABLE_ID ]\n" > " [ protocol PROTO ]\n" > " [ nat ADDRESS ]\n" missing newlines at the end of uidrange, ip_proto and sport lines; makes the help impossible to read