From: Keiichi KII <k-keiichi@bx.jp.nec.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: mpm@selenic.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs
Date: Tue, 26 Dec 2006 13:53:49 +0900 [thread overview]
Message-ID: <4590AADD.2070304@bx.jp.nec.com> (raw)
In-Reply-To: <20061223213426.aa80907e.randy.dunlap@oracle.com>
Thank you for your replies and reviews.
I will follow your advices.
>> static LIST_HEAD(target_list);
>>
>> static DEFINE_SPINLOCK(target_list_lock);
>>
>> +static ssize_t show_local_ip(struct netconsole_target *nt, char *buf)
>> +{
>> + return sprintf(buf, "%d.%d.%d.%d\n", HIPQUAD(nt->np.local_ip));
>
> I don't understand the use of HIPQUAD() here instead of
> NIPQUAD(). Explain?
>
> Also, NIPQUAD_FMT (in kernel.h) uses "%u.%u.%u.%u".
> This should probably be the same.
> Or just use: NIPQUAD_FMT "\n"
IP address is stored in the form of host byte order in netpoll structure.
So, You can't use NIPQUAD to follow the current implementation of netpoll.
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: k-keiichi@bx.jp.nec.com
next prev parent reply other threads:[~2006-12-26 4:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 12:01 [RFC][PATCH -mm 0/5] proposal for dynamic configurable netconsole Keiichi KII
2006-12-22 12:14 ` [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs Keiichi KII
2006-12-24 5:34 ` Randy Dunlap
2006-12-26 4:53 ` Keiichi KII [this message]
2006-12-22 12:15 ` [RFC][PATCH -mm 4/5] switch function of netpoll Keiichi KII
2006-12-22 12:18 ` [RFC][PATCH -mm 5/5] add "add" element in /sys/class/misc/netconsole Keiichi KII
2006-12-22 18:36 ` [RFC][PATCH -mm 0/5] proposal for dynamic configurable netconsole Stephen Hemminger
2006-12-26 4:52 ` Keiichi KII
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4590AADD.2070304@bx.jp.nec.com \
--to=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).