From: Jeff Garzik <jeff@garzik.org>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] myri10ge: match number of save_state and restore
Date: Tue, 26 Dec 2006 16:28:40 -0500 [thread overview]
Message-ID: <45919408.1050608@garzik.org> (raw)
In-Reply-To: <45867258.3050304@myri.com>
Brice Goglin wrote:
> Since pci_save_state() pushes MSI and PCIe states on a kind of stack,
> myri10ge saving the state in advance for parity recovery will push the
> state again on the stack on suspend. This leads to some memory leak.
> We add a couple additional calls to save_state and restore_state so
> that we don't leak anymore.
>
> For the future, we are thinking of a better way to recover from parity
> error without using pci_save_state().
>
> Signed-off-by: Brice Goglin <brice@myri.com>
applied 1-5
next prev parent reply other threads:[~2006-12-26 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 10:49 [PATCH 0/5] myri10ge: IRQ and pci state cleanups Brice Goglin
2006-12-18 10:50 ` [PATCH 1/5] myri10ge: match number of save_state and restore Brice Goglin
2006-12-26 21:28 ` Jeff Garzik [this message]
2006-12-18 10:50 ` [PATCH 2/5] myri10ge: move request_irq to myri10ge_open Brice Goglin
2006-12-18 10:51 ` [PATCH 3/5] myri10ge: make msi configurable at runtime through sysfs Brice Goglin
2006-12-18 10:52 ` [PATCH 4/5] myri10ge: no need to save MSI and PCIe state in the driver Brice Goglin
2006-12-18 10:52 ` [PATCH 5/5] myri10ge: handle failures in suspend and resume Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45919408.1050608@garzik.org \
--to=jeff@garzik.org \
--cc=brice@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).