* [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver
@ 2006-12-19 21:08 akpm
2006-12-26 21:41 ` Jeff Garzik
0 siblings, 1 reply; 7+ messages in thread
From: akpm @ 2006-12-19 21:08 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, burman.yan, rmk
From: Yan Burman <burman.yan@gmail.com>
Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL
pointer before dereferencing it instead of after. Remove unreferenced
variable.
Signed-off-by: Yan Burman <burman.yan@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/net/arm/ep93xx_eth.c | 4 +---
1 files changed, 1 insertion(+), 3 deletions(-)
diff -puN drivers/net/arm/ep93xx_eth.c~ep93xx-some-minor-cleanups-to-the-ep93xx-eth-driver drivers/net/arm/ep93xx_eth.c
--- a/drivers/net/arm/ep93xx_eth.c~ep93xx-some-minor-cleanups-to-the-ep93xx-eth-driver
+++ a/drivers/net/arm/ep93xx_eth.c
@@ -780,12 +780,10 @@ static struct ethtool_ops ep93xx_ethtool
struct net_device *ep93xx_dev_alloc(struct ep93xx_eth_data *data)
{
struct net_device *dev;
- struct ep93xx_priv *ep;
dev = alloc_etherdev(sizeof(struct ep93xx_priv));
if (dev == NULL)
return NULL;
- ep = netdev_priv(dev);
memcpy(dev->dev_addr, data->dev_addr, ETH_ALEN);
@@ -840,9 +838,9 @@ static int ep93xx_eth_probe(struct platf
struct ep93xx_priv *ep;
int err;
- data = pdev->dev.platform_data;
if (pdev == NULL)
return -ENODEV;
+ data = pdev->dev.platform_data;
dev = ep93xx_dev_alloc(data);
if (dev == NULL) {
_
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver 2006-12-19 21:08 [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver akpm @ 2006-12-26 21:41 ` Jeff Garzik 2006-12-26 21:42 ` Lennert Buytenhek 0 siblings, 1 reply; 7+ messages in thread From: Jeff Garzik @ 2006-12-26 21:41 UTC (permalink / raw) To: akpm; +Cc: netdev, burman.yan, rmk akpm@osdl.org wrote: > From: Yan Burman <burman.yan@gmail.com> > > Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > pointer before dereferencing it instead of after. Remove unreferenced > variable. > > Signed-off-by: Yan Burman <burman.yan@gmail.com> > Cc: Jeff Garzik <jeff@garzik.org> > Cc: Russell King <rmk@arm.linux.org.uk> > Signed-off-by: Andrew Morton <akpm@osdl.org> applied ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver 2006-12-26 21:41 ` Jeff Garzik @ 2006-12-26 21:42 ` Lennert Buytenhek 2006-12-26 21:48 ` Lennert Buytenhek ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Lennert Buytenhek @ 2006-12-26 21:42 UTC (permalink / raw) To: Jeff Garzik; +Cc: akpm, netdev, burman.yan, rmk On Tue, Dec 26, 2006 at 04:41:17PM -0500, Jeff Garzik wrote: > >Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > >pointer before dereferencing it instead of after. Remove unreferenced > >variable. > > > >Signed-off-by: Yan Burman <burman.yan@gmail.com> > >Cc: Jeff Garzik <jeff@garzik.org> > >Cc: Russell King <rmk@arm.linux.org.uk> > >Signed-off-by: Andrew Morton <akpm@osdl.org> Why wasn't I CC'ed on this? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver 2006-12-26 21:42 ` Lennert Buytenhek @ 2006-12-26 21:48 ` Lennert Buytenhek 2006-12-26 21:50 ` Jeff Garzik 2006-12-26 22:56 ` Russell King 2 siblings, 0 replies; 7+ messages in thread From: Lennert Buytenhek @ 2006-12-26 21:48 UTC (permalink / raw) To: Jeff Garzik, burman.yan; +Cc: akpm, netdev, rmk On Tue, Dec 26, 2006 at 10:42:27PM +0100, Lennert Buytenhek wrote: > > >Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > > >pointer before dereferencing it instead of after. Remove unreferenced > > >variable. > > > > > >Signed-off-by: Yan Burman <burman.yan@gmail.com> > > >Cc: Jeff Garzik <jeff@garzik.org> > > >Cc: Russell King <rmk@arm.linux.org.uk> > > >Signed-off-by: Andrew Morton <akpm@osdl.org> > > Why wasn't I CC'ed on this? Sorry, meant to ask "Yan Burman", not Jeff. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver 2006-12-26 21:42 ` Lennert Buytenhek 2006-12-26 21:48 ` Lennert Buytenhek @ 2006-12-26 21:50 ` Jeff Garzik 2006-12-26 22:56 ` Russell King 2 siblings, 0 replies; 7+ messages in thread From: Jeff Garzik @ 2006-12-26 21:50 UTC (permalink / raw) To: Lennert Buytenhek; +Cc: akpm, netdev, burman.yan, rmk Lennert Buytenhek wrote: > On Tue, Dec 26, 2006 at 04:41:17PM -0500, Jeff Garzik wrote: > >>> Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL >>> pointer before dereferencing it instead of after. Remove unreferenced >>> variable. >>> >>> Signed-off-by: Yan Burman <burman.yan@gmail.com> >>> Cc: Jeff Garzik <jeff@garzik.org> >>> Cc: Russell King <rmk@arm.linux.org.uk> >>> Signed-off-by: Andrew Morton <akpm@osdl.org> > > Why wasn't I CC'ed on this? Came via akpm, and seemed sane... Jeff, proceeding in full-speed-ahead mode :) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver 2006-12-26 21:42 ` Lennert Buytenhek 2006-12-26 21:48 ` Lennert Buytenhek 2006-12-26 21:50 ` Jeff Garzik @ 2006-12-26 22:56 ` Russell King 2006-12-28 3:38 ` [PATCH] Update CREDITS and MAINTAINERS entries for Lennert Buytenhek Lennert Buytenhek 2 siblings, 1 reply; 7+ messages in thread From: Russell King @ 2006-12-26 22:56 UTC (permalink / raw) To: Lennert Buytenhek; +Cc: Jeff Garzik, akpm, netdev, burman.yan On Tue, Dec 26, 2006 at 10:42:27PM +0100, Lennert Buytenhek wrote: > On Tue, Dec 26, 2006 at 04:41:17PM -0500, Jeff Garzik wrote: > > > >Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > > >pointer before dereferencing it instead of after. Remove unreferenced > > >variable. > > > > > >Signed-off-by: Yan Burman <burman.yan@gmail.com> > > >Cc: Jeff Garzik <jeff@garzik.org> > > >Cc: Russell King <rmk@arm.linux.org.uk> > > >Signed-off-by: Andrew Morton <akpm@osdl.org> > > Why wasn't I CC'ed on this? Probably because akpm thinks it was something to do with me... may I suggest it might help to have an entry in MAINTAINERS? -- Russell King ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Update CREDITS and MAINTAINERS entries for Lennert Buytenhek 2006-12-26 22:56 ` Russell King @ 2006-12-28 3:38 ` Lennert Buytenhek 0 siblings, 0 replies; 7+ messages in thread From: Lennert Buytenhek @ 2006-12-28 3:38 UTC (permalink / raw) To: Russell King, akpm; +Cc: Jeff Garzik, netdev, burman.yan On Tue, Dec 26, 2006 at 10:56:30PM +0000, Russell King wrote: > > > >Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL > > > >pointer before dereferencing it instead of after. Remove unreferenced > > > >variable. > > > > > > > >Signed-off-by: Yan Burman <burman.yan@gmail.com> > > > >Cc: Jeff Garzik <jeff@garzik.org> > > > >Cc: Russell King <rmk@arm.linux.org.uk> > > > >Signed-off-by: Andrew Morton <akpm@osdl.org> > > > > Why wasn't I CC'ed on this? > > Probably because akpm thinks it was something to do with me... may I > suggest it might help to have an entry in MAINTAINERS? You mean the file that still lists Bartlomiej as IDE maintainer? If people manage to miss the name and email address at the top of the very file being patched, I'm not sure whether anything else'll help, but fine, whatever. The patch below adds a MAINTAINERS entry for everything I would appreciate being CC'ed on, someone please apply it. --- From: Lennert Buytenhek <buytenh@wantstofly.org> Update CREDITS and MAINTAINERS entries for Lennert Buytenhek Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org> Index: linux-2.6.20-rc2/CREDITS =================================================================== --- linux-2.6.20-rc2.orig/CREDITS +++ linux-2.6.20-rc2/CREDITS @@ -516,9 +516,10 @@ S: Orlando, Florida S: USA N: Lennert Buytenhek -E: buytenh@gnu.org -D: Rewrite of the ethernet bridging code -S: Ravenhorst 58B +E: kernel@wantstofly.org +D: Original (2.4) rewrite of the ethernet bridging code +D: Various ARM bits and pieces +S: Ravenhorst 58 S: 2317 AK Leiden S: The Netherlands Index: linux-2.6.20-rc2/MAINTAINERS =================================================================== --- linux-2.6.20-rc2.orig/MAINTAINERS +++ linux-2.6.20-rc2/MAINTAINERS @@ -355,6 +355,24 @@ P: Ian Molton M: spyro@f2s.com S: Maintained +ARM/ADI ROADRUNNER MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/ADS SPHERE MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/AJECO 1ARM MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + ARM/ATMEL AT91RM9200 ARM ARCHITECTURE P: Andrew Victor M: andrew@sanpeople.com @@ -362,17 +380,89 @@ L: linux-arm-kernel@lists.arm.linux W: http://maxim.org.za/at91_26.html S: Maintained +ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/CIRRUS LOGIC EDB9315A MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + ARM/CORGI MACHINE SUPPORT P: Richard Purdie M: rpurdie@rpsys.net S: Maintained +ARM/GLOMATION GESBC9312SX MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + ARM/HP JORNADA 7XX MACHINE SUPPORT P: Kristoffer Ericson M: kristoffer_e1@hotmail.com W: www.jlime.com S: Maintained +ARM/INTEL IOP32X ARM ARCHITECTURE +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/INTEL IOP13XX ARM ARCHITECTURE +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/INTEL IQ81342EX MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/INTEL IXP2000 ARM ARCHITECTURE +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/INTEL IXDP2850 MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/INTEL IXP23XX ARM ARCHITECTURE +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/INTEL XSC3 (MANZANO) ARM CORE +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/IP FABRICS DOUBLE ESPRESSO MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/LOGICPD PXA270 MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + ARM/TOSA MACHINE SUPPORT P: Dirk Opfer M: dirk@opfer-online.de @@ -391,6 +481,12 @@ L: linux-arm-kernel@lists.arm.linux.org. W: http://www.arm.linux.org.uk/ S: Maintained +ARM/RADISYS ENP2611 MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + ARM/SHARK MACHINE SUPPORT P: Alexander Schulz M: alex@shark-linux.de @@ -418,6 +514,18 @@ L: linux-arm-kernel@lists.arm.linux.org. W: http://www.fluff.org/ben/linux/ S: Maintained +ARM/TECHNOLOGIC SYSTEMS TS7250 MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + +ARM/THECUS N2100 MACHINE SUPPORT +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) +S: Maintained + ARPD SUPPORT P: Jonathan Layes L: netdev@vger.kernel.org @@ -688,12 +796,24 @@ M: joel.becker@oracle.com L: linux-kernel@vger.kernel.org S: Supported +CIRRUS LOGIC EP93XX ETHERNET DRIVER +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: netdev@vger.kernel.org +S: Maintained + CIRRUS LOGIC GENERIC FBDEV DRIVER P: Jeff Garzik M: jgarzik@pobox.com L: linux-fbdev-devel@lists.sourceforge.net (subscribers-only) S: Odd Fixes +CIRRUS LOGIC EP93XX OHCI USB HOST DRIVER +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: linux-usb-devel@lists.sourceforge.net +S: Maintained + CIRRUS LOGIC CS4280/CS461x SOUNDDRIVER P: Cirrus Logic Corporation (kernel 2.2 driver) M: Cirrus Logic Corporation, Thomas Woller <twoller@crystal.cirrus.com> @@ -1563,6 +1683,12 @@ P: Deepak Saxena M: dsaxena@plexity.net S: Maintained +INTEL IXP2000 ETHERNET DRIVER +P: Lennert Buytenhek +M: kernel@wantstofly.org +L: netdev@vger.kernel.org +S: Maintained + INTEL PRO/100 ETHERNET SUPPORT P: John Ronciak M: john.ronciak@intel.com ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2006-12-28 3:38 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-12-19 21:08 [patch 5/7] ep93xx: some minor cleanups to the ep93xx eth driver akpm 2006-12-26 21:41 ` Jeff Garzik 2006-12-26 21:42 ` Lennert Buytenhek 2006-12-26 21:48 ` Lennert Buytenhek 2006-12-26 21:50 ` Jeff Garzik 2006-12-26 22:56 ` Russell King 2006-12-28 3:38 ` [PATCH] Update CREDITS and MAINTAINERS entries for Lennert Buytenhek Lennert Buytenhek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).