From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [patch 0/6] sky2 driver update (v1.11)
Date: Tue, 26 Dec 2006 16:44:24 -0500 [thread overview]
Message-ID: <459197B8.6010403@pobox.com> (raw)
In-Reply-To: <20061220210632.183204605@osdl.org>
Stephen Hemminger wrote:
> Patches are in order of severity. 1-3 are bug fixes, 4 is a cleanup
> of the power state code, and 5 adds wake on lan support.
>
> IMHO, it is bad security policy to allow wake on lan to enabled by default.
> The sky2 driver doesn't do WOL until enabled with ethtool.
While in general I agree with you on the security principle, this seems
like it might break working setups.
WOL is a partnership between the motherboard and NIC. The motherboard
must support WOL, or its useless. And since the motherboard must
support WOL, it normally has an on/off switch in BIOS.
As such, you're overriding the admin's chosen BIOS setting here.
Jeff
next prev parent reply other threads:[~2006-12-26 21:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 21:06 [patch 0/6] sky2 driver update (v1.11) Stephen Hemminger
2006-12-20 21:06 ` [patch 1/6] sky2: dual port NAPI problem Stephen Hemminger
2006-12-26 21:36 ` Jeff Garzik
2006-12-20 21:06 ` [patch 2/6] sky2: power management/MSI workaround Stephen Hemminger
2006-12-20 21:06 ` [patch 3/6] sky2: phy power down needs PCI config write enabled Stephen Hemminger
2006-12-20 21:06 ` [patch 4/6] sky2: better power state management Stephen Hemminger
2006-12-26 21:37 ` Jeff Garzik
2006-12-20 21:06 ` [patch 5/6] sky2: add Wake On Lan support Stephen Hemminger
2006-12-20 21:06 ` [patch 6/6] sky2: version 1.11 Stephen Hemminger
2006-12-26 21:44 ` Jeff Garzik [this message]
2007-01-01 18:36 ` [patch 0/6] sky2 driver update (v1.11) Stephen Hemminger
2007-01-02 19:10 ` Tino Keitel
2007-01-13 13:03 ` Tino Keitel
2007-01-15 18:21 ` Stephen Hemminger
2007-01-15 19:12 ` Tino Keitel
2007-01-02 21:52 ` Gerd v. Egidy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459197B8.6010403@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).