From: Jan Kiszka <jan.kiszka@web.de>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: Jiri Benc <jbenc@suse.cz>, Christoph Hellwig <hch@infradead.org>,
netdev@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH] d80211: Fix inconsistent sta_lock usage
Date: Sat, 06 Jan 2007 17:33:28 +0100 [thread overview]
Message-ID: <459FCF58.1060206@web.de> (raw)
In-Reply-To: <200701052108.40185.IvDoorn@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
Ivo van Doorn wrote:
> +#define __bss_tim_set(__bss, __aid) __set_bit((__aid), &(__bss)->tim)
> +
__set/clear_bit demands unsigned long, tim is u8. That causes quite some
warnings here.
...
> static inline void bss_tim_clear(struct ieee80211_local *local,
> struct ieee80211_if_ap *bss, int aid)
> {
> spin_lock(&local->sta_lock);
> - bss->tim[(aid)/8] &= !(1<<((aid) % 8));
> + __bss_tim_clear(bss, aid);
> spin_unlock(&local->sta_lock);
Probably forgotten: we need _bh here as well.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]
next prev parent reply other threads:[~2007-01-06 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 20:19 [PATCH] d80211: Fix inconsistent sta_lock usage Jan Kiszka
2007-01-02 15:30 ` Ivo Van Doorn
2007-01-02 16:22 ` Christoph Hellwig
2007-01-05 20:08 ` Ivo van Doorn
2007-01-06 16:33 ` Jan Kiszka [this message]
2007-01-06 16:52 ` Johannes Berg
2007-01-06 16:59 ` Johannes Berg
2007-01-06 17:00 ` Jan Kiszka
2007-01-06 17:01 ` Johannes Berg
2007-01-06 19:09 ` Ivo Van Doorn
2007-01-10 20:13 ` Jiri Benc
2007-01-06 16:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459FCF58.1060206@web.de \
--to=jan.kiszka@web.de \
--cc=hch@infradead.org \
--cc=ivdoorn@gmail.com \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).