From: Auke Kok <auke-jan.h.kok@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, NetDev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: [PATCH -MM] e1000: rewrite hardware initialization code
Date: Tue, 09 Jan 2007 09:36:29 -0800 [thread overview]
Message-ID: <45A3D29D.1000202@intel.com> (raw)
Andrew, All,
This patch contains a major rewrite to the e1000 driver that groups and separates e1000
hardware by chipset family. It abstracts the hardware specific code into an API that
will allow us to continue to maintain the complex e1000 driver and add new hardware
support to it without touching code that affects older chipsets. It de-complexifies a
significant part of the e1000 driver.
This is the first and largest part of e1000 changes that have been long overdue. Thanks
to Jeb Cramer working on this, as well as our validation team, this code is getting
ready for general consumption. We hope to get started on adding a better way of handling
feature flags and workarounds to the complex e1000 driver quickly.
We're submitting this code to -mm for obvious reasons: we are still testing the code and
want the community feedback on this large change, while giving the linux community an
early chance to test and use the new driver before it goes mainstream.
The patch addresses the following issues:
* separates hardware-specific code by chipset family and provides a single API for all
chipsets (effectively a lib-e1000)
* maintains a single driver for the user, no external changes
* will allow the user in the future to select specific hardware support instead of all
Some cosmetic changes were also made. This driver adds more header and code files to
separate the new parts of the code (chipsets, api, nvm, mac & phy layers). All
whitespace was changed to linux indentation and integer data types were converted to
{u,s}{8,16,32,64} types instead of uintNN_t types.
The total size of the patch is 1.2mb plaintext, and too large to post to any of the
lists. I've provided several ways of receiving the patch:
(1)
git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000
The patch here applies against 2.6.20-rc3-mm1.
(2)
http://foo-projects.org/~sofar/e1000_hw_init_layer_rewrite.patch (1.2mb)
or
http://foo-projects.org/~sofar/e1000_hw_init_layer_rewrite.patch.bz2 (162k)
I'll gladly e-mail the patch to anyone who wishes to receive it by e-mail.
Andrew, please pull from our git tree listed above to receive the patch. I expect in the
coming few weeks to provide updates to this patch as issues that come up are resolved.
Cheers,
Auke
---
e1000: rewrite of HW code library
From: Jeb Cramer <cramerj@intel.com>
This rewrite of the hardware initialization code splits up the driver
low-level initialization code per chipset family. Several families exist
with different initialization code per chipset, revision, and this allows
us later to select only enable certain devices in the driver. The current
code enables all previous drivers and thus doesn't change anything to the
user, but is radically different internally.
Mac and phy layers are also split, and everything is grouped in an API
layer that the driver uses to interface the hardware.
Support was added for a PCI-e 4-port Fibre version of the PRO/1000 PT quad
port adapter (device 0x10a5). MTU changes on a downed interface require
a phy commit to enact the new size immediately.
Signed-off-by: Jeb Cramer <cramerj@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000/Makefile | 19
drivers/net/e1000/e1000.h | 95
drivers/net/e1000/e1000_80003es2lan.c | 1330 +++++
drivers/net/e1000/e1000_80003es2lan.h | 89
drivers/net/e1000/e1000_82540.c | 586 ++
drivers/net/e1000/e1000_82541.c | 1164 ++++
drivers/net/e1000/e1000_82541.h | 86
drivers/net/e1000/e1000_82542.c | 466 ++
drivers/net/e1000/e1000_82543.c | 1397 +++++
drivers/net/e1000/e1000_82543.h | 45
drivers/net/e1000/e1000_82571.c | 1132 ++++
drivers/net/e1000/e1000_82571.h | 42
drivers/net/e1000/e1000_api.c | 1077 ++++
drivers/net/e1000/e1000_api.h | 159 +
drivers/net/e1000/e1000_defines.h | 1289 +++++
drivers/net/e1000/e1000_ethtool.c | 470 +-
drivers/net/e1000/e1000_hw.c | 9038 ---------------------------------
drivers/net/e1000/e1000_hw.h | 3859 ++------------
drivers/net/e1000/e1000_ich8lan.c | 2353 +++++++++
drivers/net/e1000/e1000_ich8lan.h | 108
drivers/net/e1000/e1000_mac.c | 1921 +++++++
drivers/net/e1000/e1000_mac.h | 84
drivers/net/e1000/e1000_main.c | 1002 ++--
drivers/net/e1000/e1000_manage.c | 387 +
drivers/net/e1000/e1000_manage.h | 83
drivers/net/e1000/e1000_nvm.c | 860 +++
drivers/net/e1000/e1000_nvm.h | 61
drivers/net/e1000/e1000_osdep.h | 56
drivers/net/e1000/e1000_param.c | 115
drivers/net/e1000/e1000_phy.c | 1932 +++++++
drivers/net/e1000/e1000_phy.h | 157 +
drivers/net/e1000/e1000_regs.h | 236 +
32 files changed, 18538 insertions(+), 13160 deletions(-)
next reply other threads:[~2007-01-09 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 17:36 Auke Kok [this message]
2007-01-09 18:33 ` [PATCH -MM] e1000: rewrite hardware initialization code Stephen Hemminger
2007-01-09 18:48 ` Auke Kok
2007-01-09 18:45 ` Andrew Morton
2007-01-09 19:10 ` Auke Kok
2007-01-09 22:24 ` Auke Kok
2007-01-09 19:16 ` Krzysztof Halasa
2007-01-09 19:24 ` Randy Dunlap
2007-01-09 19:45 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A3D29D.1000202@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).