[2.6 patch] make hdlc_setup() static again

[2.6 patch] make hdlc_setup() static again

[Adrian Bunk]

hdlc_setup was exported, but this export was never used.

If a driver using it actually shows up it can still be exported again.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Krzysztof Halasa <khc@pm.waw.pl>

---

This patch was already sent on:
- 25 Nov 2006

--- linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c.old	2006-11-25 00:16:13.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c	2006-11-25 00:16:26.000000000 +0100
@@ -222,7 +222,7 @@
 	return -EINVAL;
 }
 
-void hdlc_setup(struct net_device *dev)
+static void hdlc_setup(struct net_device *dev)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
 
@@ -325,7 +325,6 @@
 EXPORT_SYMBOL(hdlc_open);
 EXPORT_SYMBOL(hdlc_close);
 EXPORT_SYMBOL(hdlc_ioctl);
-EXPORT_SYMBOL(hdlc_setup);
 EXPORT_SYMBOL(alloc_hdlcdev);
 EXPORT_SYMBOL(unregister_hdlc_device);
 EXPORT_SYMBOL(register_hdlc_protocol);

Re: [2.6 patch] make hdlc_setup() static again

[Jeff Garzik]

Adrian Bunk wrote:
> hdlc_setup was exported, but this export was never used.
> 
> If a driver using it actually shows up it can still be exported again.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Acked-by: Krzysztof Halasa <khc@pm.waw.pl>

applied

-git: Why is drivers/net/wan/hdlc_generic.c:hdlc_setup() exported?

[Adrian Bunk]

Commit 4a31e348e3ecaf54c50240109ac4574b180f8840 added an 
EXPORT_SYMBOL(hdlc_setup) with the justification
   hdlc_setup() is now EXPORTed as per David's request.

Is a usage of this export pending for the near future or could this 
export be reverted until a user is submitted for inclusion?

TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: -git: Why is drivers/net/wan/hdlc_generic.c:hdlc_setup() exported?

[Krzysztof Halasa]

Adrian Bunk <bunk@stusta.de> writes:

>    hdlc_setup() is now EXPORTed as per David's request.
>
> Is a usage of this export pending for the near future

I'm told it is.
-- 
Krzysztof Halasa

[2.6 patch] make hdlc_setup() static again

[Adrian Bunk]

On Mon, Jun 26, 2006 at 09:28:14PM +0200, Krzysztof Halasa wrote:
> Adrian Bunk <bunk@stusta.de> writes:
> 
> >    hdlc_setup() is now EXPORTed as per David's request.
> >
> > Is a usage of this export pending for the near future
> 
> I'm told it is.

It's still not used...

So let's unexport it again until some driver that actually uses it shows up.

> Krzysztof Halasa

cu
Adrian


<--  snip  -->


hdlc_setup was exported, but this export was never used.

If adriver using it actually shows up it can still be exported again.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c.old	2006-11-25 00:16:13.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c	2006-11-25 00:16:26.000000000 +0100
@@ -222,7 +222,7 @@
 	return -EINVAL;
 }
 
-void hdlc_setup(struct net_device *dev)
+static void hdlc_setup(struct net_device *dev)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
 
@@ -325,7 +325,6 @@
 EXPORT_SYMBOL(hdlc_open);
 EXPORT_SYMBOL(hdlc_close);
 EXPORT_SYMBOL(hdlc_ioctl);
-EXPORT_SYMBOL(hdlc_setup);
 EXPORT_SYMBOL(alloc_hdlcdev);
 EXPORT_SYMBOL(unregister_hdlc_device);
 EXPORT_SYMBOL(register_hdlc_protocol);

Re: [2.6 patch] make hdlc_setup() static again

[Krzysztof Halasa]

Adrian Bunk <bunk@stusta.de> writes:

> It's still not used...
>
> So let's unexport it again until some driver that actually uses it shows up.

Fair enough.
-- 
Krzysztof Halasa