* [2.6 patch] bonding.h: "extern inline" -> "static inline"
@ 2006-12-12 16:24 Adrian Bunk
2007-01-19 3:07 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-12-12 16:24 UTC (permalink / raw)
To: Jay Vosburgh; +Cc: Jeff Garzik, ctindel, bonding-devel, netdev
"extern inline" generates a warning with -Wmissing-prototypes and I'm
currently working on getting the kernel cleaned up for adding this to
the CFLAGS since it will help us to avoid a nasty class of runtime
errors.
If there are places that really need a forced inline, __always_inline
would be the correct solution.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/bonding/bonding.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.19-mm1/drivers/net/bonding/bonding.h.old 2006-12-12 15:57:43.000000000 +0100
+++ linux-2.6.19-mm1/drivers/net/bonding/bonding.h 2006-12-12 15:58:17.000000000 +0100
@@ -237,12 +237,13 @@
#define BOND_ARP_VALIDATE_ALL (BOND_ARP_VALIDATE_ACTIVE | \
BOND_ARP_VALIDATE_BACKUP)
-extern inline int slave_do_arp_validate(struct bonding *bond, struct slave *slave)
+static inline int slave_do_arp_validate(struct bonding *bond,
+ struct slave *slave)
{
return bond->params.arp_validate & (1 << slave->state);
}
-extern inline u32 slave_last_rx(struct bonding *bond, struct slave *slave)
+static inline u32 slave_last_rx(struct bonding *bond, struct slave *slave)
{
if (slave_do_arp_validate(bond, slave))
return slave->last_arp_rx;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] bonding.h: "extern inline" -> "static inline"
2006-12-12 16:24 [2.6 patch] bonding.h: "extern inline" -> "static inline" Adrian Bunk
@ 2007-01-19 3:07 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-01-19 3:07 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Jay Vosburgh, ctindel, bonding-devel, netdev
Adrian Bunk wrote:
> "extern inline" generates a warning with -Wmissing-prototypes and I'm
> currently working on getting the kernel cleaned up for adding this to
> the CFLAGS since it will help us to avoid a nasty class of runtime
> errors.
>
> If there are places that really need a forced inline, __always_inline
> would be the correct solution.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-19 3:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-12 16:24 [2.6 patch] bonding.h: "extern inline" -> "static inline" Adrian Bunk
2007-01-19 3:07 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).