netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: linville@tuxdriver.com
Cc: netdev@vger.kernel.org
Subject: [RFC] airo.c: Description and function is not the same
Date: Sun, 21 Jan 2007 13:01:26 +0100	[thread overview]
Message-ID: <45B35616.6040103@student.ltu.se> (raw)

Hello

In the tour of converting local definitions of boolean-type/values, I 
ran into airo.c's description of ex decapsulate():

 *      Returns: BOOLEAN - TRUE if packet should be dropped otherwise FALSE

but returns SUCCESS (defined as 0) and ERROR (defined as -1).

Also, shouldn't those functions be converted to return 'bool' when the 
description say so (happy to do it).

Richard Knutsson


             reply	other threads:[~2007-01-21 11:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-21 12:01 Richard Knutsson [this message]
2007-01-23 15:11 ` [RFC] airo.c: Description and function is not the same Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45B35616.6040103@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).