From: Jay Cliburn <jacliburn@bellsouth.net>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: jeff@garzik.org, shemminger@osdl.org, csnook@redhat.com,
hch@infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, atl1-devel@lists.sourceforge.net,
kronos.it@gmail.com
Subject: Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver
Date: Sun, 21 Jan 2007 21:33:39 -0600 [thread overview]
Message-ID: <45B43093.6060500@bellsouth.net> (raw)
In-Reply-To: <20070121183151.4be61ebf.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote:
[snip]
>> + value = ioread16(hw->hw_addr + REG_PCIE_CAP_LIST);
>> + return ((value & 0xFF00) == 0x6C00) ? 0 : 1;
>
> Are there defines or enums for these?
> Fewer magic numbers would be nice/helpful/readable.
[snip]
>> + s32 ret;
>> + ret = atl1_write_phy_reg(hw, 29, 0x0029);
>
> Fewer magic numbers?
Unfortunately, we don't have a spec. This is how the vendor coded it.
[snip]
>> +
>> +int enable_msi;
>> +module_param(enable_msi, int, 0444);
>> +MODULE_PARM_DESC(enable_msi, "Enable PCI MSI");
>
> Hm, I thought that we didn't want individual drivers having MSI config
> options...
Luca? This one was yours IIRC. Care to chime in?
Randy, thank you for the review.
Jay
next prev parent reply other threads:[~2007-01-22 3:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-21 21:07 [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver Jay Cliburn
2007-01-22 2:31 ` Randy Dunlap
2007-01-22 3:33 ` Jay Cliburn [this message]
2007-01-22 20:00 ` Luca Tettamanti
2007-01-23 19:25 ` Stephen Hemminger
2007-01-23 21:19 ` Luca Tettamanti
2007-01-27 21:02 ` Jay Cliburn
2007-01-27 21:15 ` Jeff Garzik
2007-01-27 22:05 ` Jay Cliburn
2007-01-27 22:38 ` Jeff Garzik
2007-01-23 21:33 ` Jeff Garzik
2007-01-23 21:34 ` Stephen Hemminger
2007-01-23 21:46 ` Randy Dunlap
2007-01-23 22:06 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-01-11 0:43 Jay Cliburn
2007-01-11 9:37 ` Christoph Hellwig
2007-01-19 3:00 ` Jeff Garzik
2006-11-19 20:31 Jay Cliburn
2006-11-20 12:40 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B43093.6060500@bellsouth.net \
--to=jacliburn@bellsouth.net \
--cc=atl1-devel@lists.sourceforge.net \
--cc=csnook@redhat.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).