From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver Date: Tue, 23 Jan 2007 17:06:35 -0500 Message-ID: <45B686EB.60508@garzik.org> References: <20070121210737.GE2702@osprey.hogchain.net> <20070121183151.4be61ebf.randy.dunlap@oracle.com> <45B43093.6060500@bellsouth.net> <20070122200004.GA12553@dreamland.darkstar.lan> <20070123112522.65aac61b@freekitty> <45B67F29.4010703@garzik.org> <20070123133409.17a32128@freekitty> <45B68249.90507@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , Luca Tettamanti , Jay Cliburn , shemminger@osdl.org, csnook@redhat.com, hch@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, atl1-devel@lists.sourceforge.net Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:51168 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965547AbXAWWGx (ORCPT ); Tue, 23 Jan 2007 17:06:53 -0500 To: Randy Dunlap In-Reply-To: <45B68249.90507@oracle.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Randy Dunlap wrote: > Stephen Hemminger wrote: >> On Tue, 23 Jan 2007 16:33:29 -0500 >> Jeff Garzik wrote: >> >>> Stephen Hemminger wrote: >>>> IMHO the MSI disabling should be removed from drivers and be done >>>> in the PCI core. >>> That is the consensus opinion. >>> >>> Currently drivers implement the MSI tests because the core PCI code >>> hasn't been up to snuff. I (and others) have been discouraging that, >>> but when a user faces a choice between working and non-working >>> network, the pragmatic solution wins. > > Linus's remark (IIRC) was to not enable CONFIG_PCI_MSI then. Most distros, especially cutting edge ones like Fedora, will enable CONFIG_PCI_MSI. >>> All efforts to get us to the point where we can remove the MSI tests >>> from drivers are strongly supported... >>> >>> Jeff >> >> So far, either MSI works for all devices or is broken, so it makes >> sense to have a "msi=off" boot option (if there isn't already) >> > There is one, but it's spelled "pci=nomsi". Yep. Thanks for repeating this, and refreshing the collective memory. Jeff