netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
To: davem@davemloft.net, yoshfuji@linux-ipv6.org,
	herbert@gondor.apana.org.au
Cc: nakagawa.msy@ncos.nec.co.jp, mhuth@mvista.com, netdev@vger.kernel.org
Subject: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()
Date: Thu, 25 Jan 2007 19:37:07 -0800	[thread overview]
Message-ID: <45B97763.8000305@ncos.nec.co.jp> (raw)

This patch simply replaces __kfree_skb() in exit path with kfree_skb().
In tcp_rcv_state_process(), generally skbs should be destroyed only when
the ref count is zero.
That is the way things are supposed to be done in the kernel.

This change might reveals a memory leak of skb.
If it happens, it would be because someone doesn't deal with the skb properly.

Signed-off-by: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>

--- linux-2.6/net/ipv4/tcp_input.c.orig	2007-01-25 07:04:35.000000000 -0800
+++ linux-2.6/net/ipv4/tcp_input.c	2007-01-25 07:05:05.000000000 -0800
@@ -4423,8 +4423,6 @@ int tcp_rcv_state_process(struct sock *s
 			 * in the interest of security over speed unless
 			 * it's still in use.
 			 */
-			kfree_skb(skb);
-			return 0;
 		}
 		goto discard;

@@ -4634,7 +4632,7 @@ int tcp_rcv_state_process(struct sock *s

 	if (!queued) {
 discard:
-		__kfree_skb(skb);
+		kfree_skb(skb);
 	}
 	return 0;
 }

             reply	other threads:[~2007-01-26  3:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-26  3:37 Masayuki Nakagawa [this message]
2007-01-26  8:28 ` [PATCH] TCP: Replace __kfree_skb() with kfree_skb() Jarek Poplawski
2007-01-26  9:16   ` Herbert Xu
2007-01-26  9:49     ` Jarek Poplawski
2007-01-26  9:52       ` Herbert Xu
2007-01-26 10:18         ` Jarek Poplawski
2007-01-26 10:45           ` Herbert Xu
2007-01-26 10:58             ` David Miller
2007-01-26 11:02             ` Jarek Poplawski
2007-01-26 13:18               ` Jarek Poplawski
2007-01-26 14:05                 ` Jarek Poplawski
2007-01-26 14:19             ` Alexey Kuznetsov
2007-01-29  8:26             ` Jarek Poplawski
2007-01-29 10:38               ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45B97763.8000305@ncos.nec.co.jp \
    --to=nakagawa.msy@ncos.nec.co.jp \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=mhuth@mvista.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).