From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection Date: Fri, 26 Jan 2007 16:42:41 -0500 Message-ID: <45BA75D1.6040005@hp.com> References: <20070125133340.GA8891@hmsreliant.homelinux.net> <45B8E60B.7080809@hp.com> <20070125194500.GB8891@hmsreliant.homelinux.net> <20070126.091331.22638713.yoshfuji@linux-ipv6.org> <20070126191817.GC15916@hmsreliant.homelinux.net> <45BA6478.4020304@hp.com> <20070126213524.GD15916@hmsreliant.homelinux.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?B?WU9TSElGVUpJIEhpZGVha2kgLyDlkInol6Toi7HmmI4=?= , sri@us.ibm.com, davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, kaber@coreworks.de, netdev@vger.kernel.org To: Neil Horman Return-path: Received: from atlrel9.hp.com ([156.153.255.214]:34243 "EHLO atlrel9.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbXAZVmn (ORCPT ); Fri, 26 Jan 2007 16:42:43 -0500 In-Reply-To: <20070126213524.GD15916@hmsreliant.homelinux.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Neil Horman wrote: > On Fri, Jan 26, 2007 at 03:28:40PM -0500, Vlad Yasevich wrote: >> Hi Neil >> >> Neil Horman wrote: >>> On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / =E5=90= =89=E8=97=A4=E8=8B=B1=E6=98=8E wrote: >>>> In article <20070125194500.GB8891@hmsreliant.homelinux.net> (at Th= u, 25 Jan 2007 14:45:00 -0500), Neil Horman say= s: >>> >>> New patch attached with most of your suggestions incorporated. I'v= e a few >>> comments mixed in for some of the suggestions that I think need fur= ther >>> discussion >>> >>>> If optimistic_dad is disabled, flags should be IFA_F_TEMPORARY, >>>> not IFA_F_TEMPORARY|IFA_F_OPTIMISTIC. >>>> >>>> Another idea is to use IFA_F_OPTIMISTIC not >>>> IFA_F_OPTIMISTIC|IFA_F_TENTATIVE until the DAD has been finished. >>>> >>> I'm currently setting the OPTIMISTIC flag in every location that it= s possibly >>> needed, and then clearing it in addrconf_dad_start if that interfac= e is not >>> participating in optimistic dad. I do this because the RFC in sect= ion 3.1 >>> indicates that manually configured addresses should not set the opt= imistic flag. >>> If I removed the OPTIMISTIC flag from the locations it gets set in = the patch and >>> then only set it for participating interfaces in addrconf_dad_start= , I would >>> need to have some way to tell if the address in question was manual= ly configured >>> (to avoid setting it in that case). At present I see no clear way = to do that, >>> but if you have a suggestion, I'll happily change this around. >> One suggestiong/question: >> >> Instead of clearing the OPTIMISTIC flag in addrconf_dad_start(), wou= ldn't it be better >> to simply not set the flag in ipv6_add_addr()? Just mask that flag = from the 'flags' >> argument passed to that function when conditions are right. >> > Doh! Sometimes I don't just think straight. Yes, as long as ipv6_ad= d_addr is > only for adding static addresses (which it pretty clearly is), that w= ould work > much better. I'll fix it up and repost on monday. >=20 > Don't suppose you have any thoughts on how to solve the "send to defa= ult router" > problem, do you? >=20 Still trying to figure how the routing side works. sorry.... -vlad