From: Jeff Garzik <jeff@garzik.org>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: csnook@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, atl1-devel@lists.sourceforge.net,
randy.dunlap@oracle.com, kronos.it@gmail.com
Subject: Re: [PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI
Date: Tue, 30 Jan 2007 09:41:32 -0500 [thread overview]
Message-ID: <45BF591C.20701@garzik.org> (raw)
In-Reply-To: <20070128001004.GA10269@osprey.hogchain.net>
Jay Cliburn wrote:
> From: Luca Tettamanti <kronos.it@gmail.com>
>
> Unconditionally enable MSI in atl1 driver. Also remove some useless
> #ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not
> configured in.
>
> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
> Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
applied patches 1-4 to #atl1
The only remaining problem with your patches is that they added trailing
whitespace:
[jgarzik@pretzel netdev-2.6]$ git-am --signoff --utf8 /g/tmp/mbox
Applying 'atl1: unconditionally enable MSI'
Adds trailing whitespace.
.dotest/patch:44:
warning: 1 line adds trailing whitespaces.
Wrote tree dc738e9c0b8becc628dc3bdbbcb02988b671065a
Committed: ab248491d6e576228710950e3d21ea0731aa2de4
Applying 'atl1: add missing include dma-mapping.h'
Wrote tree 5fb3cad9771ccb59d7e3610367bb69bb33b3b45d
Committed: 13b6ae2c23523e808530681e16998220150c881c
Applying 'atl1: properly use CONFIG_PM'
Wrote tree 9fb334ce776443d59039aaedcd6a5a09790a3d67
Committed: 01e8d5606f0732222baf9ec8664d1e833ac428ca
Applying 'atl1: incorporate reviewer comments'
Adds trailing whitespace.
.dotest/patch:197:static int atl1_get_settings(struct net_device *netdev,
Adds trailing whitespace.
.dotest/patch:230:static int atl1_set_settings(struct net_device *netdev,
Adds trailing whitespace.
.dotest/patch:240: printk(KERN_DEBUG "%s: ethtool shutting
down adapter\n",
Adds trailing whitespace.
.dotest/patch:258: } else
Adds trailing whitespace.
.dotest/patch:292:
warning: squelched 10 whitespace errors
warning: 15 lines add trailing whitespaces.
Wrote tree 75ab9e0e86a96951c542b1f6e7557c917ca6799b
Committed: 37e12a2bd50cb62add05b97fc6661d21782f232b
prev parent reply other threads:[~2007-01-30 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 0:10 [PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI Jay Cliburn
2007-01-28 2:06 ` Jay Cliburn
2007-01-30 14:41 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BF591C.20701@garzik.org \
--to=jeff@garzik.org \
--cc=atl1-devel@lists.sourceforge.net \
--cc=csnook@redhat.com \
--cc=jacliburn@bellsouth.net \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).