From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_prio: class statistics printing enabled
Date: Wed, 31 Jan 2007 16:23:04 +0100 [thread overview]
Message-ID: <45C0B458.1090703@trash.net> (raw)
In-Reply-To: <20070131151721.GA3811@ff.dom.local>
Jarek Poplawski wrote:
> On Wed, Jan 31, 2007 at 04:06:05PM +0100, Patrick McHardy wrote:
>
>>The class passed to both ->dump and ->dump_stats is not a classid but
>>a qdisc-internal identifier (pointer, integer, whatever) which comes
>>from either ->get or ->walk, and thus is valid unless these functions
>>have bugs. Your check would cover the bug up and has no other purpose.
>
>
> Maybe I miss something, but it's not "my check".
I don't care.
> I tried only to "stay in line with the remaining file"...
Keeping in line may make sense in case of coding style, but its
no replacement for understanding the code you're copying around.
The same check in prio_get is correct and necessary, while in
the function you add it is incorrect and covers up potential bugs.
So please remove it so we can stop this pointless discussion.
next prev parent reply other threads:[~2007-01-31 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 7:53 [PATCH][NET_SCHED] sch_prio: class statistics printing enabled Jarek Poplawski
2007-01-31 13:47 ` Patrick McHardy
2007-01-31 14:31 ` Jarek Poplawski
2007-01-31 14:35 ` Patrick McHardy
2007-01-31 14:35 ` Jarek Poplawski
2007-01-31 14:37 ` Patrick McHardy
2007-01-31 15:01 ` Jarek Poplawski
2007-01-31 15:06 ` Patrick McHardy
2007-01-31 15:17 ` Jarek Poplawski
2007-01-31 15:23 ` Patrick McHardy [this message]
2007-01-31 15:22 ` Jarek Poplawski
2007-01-31 15:23 ` Patrick McHardy
2007-01-31 20:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C0B458.1090703@trash.net \
--to=kaber@trash.net \
--cc=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).