From: John Heffner <jheffner@psc.edu>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] apply cwnd rules to FIN packets with data
Date: Mon, 05 Feb 2007 18:02:19 -0500 [thread overview]
Message-ID: <45C7B77B.9060506@psc.edu> (raw)
In-Reply-To: <20070205.145615.92339659.davem@davemloft.net>
David Miller wrote:
> From: John Heffner <jheffner@psc.edu>
> Date: Mon, 05 Feb 2007 16:58:18 -0500
>
>> This is especially important with TSO enabled. Currently, it will send
>> a burst of up to 64k at the end of a connection, even when cwnd is much
>> smaller than 64k. This patch still lets out empty FIN packets, but does
>> not apply the special case to FINs carrying data.
>
> Good catch John.
>
> But I think the correct test on skb->len would be to just make
> sure that it is <= REAL_MSS.
>
> What do you think about that? This would match the original intention
> of the logic in the pre-TSO days.
What was the intention of that logic?
Actually, I think it would be better to leave the Nagle test as it was
(which is implicitly < real_mss), because there is obviously no point in
doing the nagle test when you know there is no more data that will be
sent. However, I can't think of any reason why the cwnd test should not
apply.
-John
next prev parent reply other threads:[~2007-02-05 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 21:58 [PATCH] apply cwnd rules to FIN packets with data John Heffner
2007-02-05 22:56 ` David Miller
2007-02-05 23:02 ` John Heffner [this message]
2007-02-05 23:08 ` David Miller
2007-02-06 0:11 ` John Heffner
2007-02-06 0:20 ` Rick Jones
2007-02-06 0:25 ` John Heffner
2007-02-06 1:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C7B77B.9060506@psc.edu \
--to=jheffner@psc.edu \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).