From mboxrd@z Thu Jan 1 00:00:00 1970 From: Auke Kok Subject: Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate Date: Tue, 06 Feb 2007 08:48:05 -0800 Message-ID: <45C8B145.7030604@intel.com> References: <20070205165429.GD3896@Ahmed> <20070205165933.GL3896@Ahmed> <20070205201804.GC11055@martell.zuzino.mipt.ru> <45C7941E.2050305@intel.com> <20070206100025.GA14903@Ahmed> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexey Dobriyan , jeffrey.t.kirsher@intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: "Ahmed S. Darwish" Return-path: Received: from mga09.intel.com ([134.134.136.24]:43375 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932588AbXBFQsI (ORCPT ); Tue, 6 Feb 2007 11:48:08 -0500 In-Reply-To: <20070206100025.GA14903@Ahmed> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Ahmed S. Darwish wrote: > On Mon, Feb 05, 2007 at 12:31:26PM -0800, Auke Kok wrote: >> Alexey Dobriyan wrote: >>> On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: >>>> A patch to use ARRAY_SIZE macro already defined in kernel.h. >>> Remove it and use ARRAY_SIZE instead. >>> >>>> --- a/drivers/net/ixgb/ixgb_param.c >>>> +++ b/drivers/net/ixgb/ixgb_param.c >>>> @@ -245,7 +245,7 @@ ixgb_validate_option(int *value, struct ixgb_option >>>> *opt) >>>> return -1; >>>> } >>>> >>>> -#define LIST_LEN(l) (sizeof(l) / sizeof(l[0])) >>>> +#define LIST_LEN(l) ARRAY_SIZE(l) >> yes, well spotted. Please change line 338 in this file to read: >> >> .arg = { .l = { .nr = ARRAY_SIZE(fc_list), >> >> instead, so you can remove the LIST_LEN macro completely. > > Thanks, Here's the new patch. > > Use ARRAY_SIZE macro when appropriate. > > Signed-off-by: Ahmed S. Darwish Acked-by: Auke Kok Cheers, Auke > --- > diff --git a/drivers/net/ixgb/ixgb_param.c b/drivers/net/ixgb/ixgb_param.c > index b27442a..c38ce73 100644 > --- a/drivers/net/ixgb/ixgb_param.c > +++ b/drivers/net/ixgb/ixgb_param.c > @@ -245,8 +245,6 @@ ixgb_validate_option(int *value, struct ixgb_option *opt) > return -1; > } > > -#define LIST_LEN(l) (sizeof(l) / sizeof(l[0])) > - > /** > * ixgb_check_options - Range Checking for Command Line Parameters > * @adapter: board private structure > @@ -335,7 +333,7 @@ ixgb_check_options(struct ixgb_adapter *adapter) > .name = "Flow Control", > .err = "reading default settings from EEPROM", > .def = ixgb_fc_tx_pause, > - .arg = { .l = { .nr = LIST_LEN(fc_list), > + .arg = { .l = { .nr = ARRAY_SIZE(fc_list), > .p = fc_list }} > }; > >