From: Larry Finger <larry.finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx: Fix for oops on resume
Date: Wed, 07 Feb 2007 07:23:45 -0600 [thread overview]
Message-ID: <45C9D2E1.7040906@lwfinger.net> (raw)
In-Reply-To: <1170850549.6798.22.camel@johannes.berg>
Johannes Berg wrote:
> On Tue, 2007-02-06 at 11:39 -0600, Larry Finger wrote:
>> There is a kernel oops on bcm43xx when resuming due to an overly tight timeout loop.
>
> Come to think of it... Is there any chance of fixing the actual oops
> that happens in this case? I can imagine broken hardware or firmware
> that causes this as well and we don't really want to oops in that case
> either... That's why we have the timeout in the first place, to not hang
> there forever.
>
> Nothing against this patch though.
As you suggested earlier, a slow clock setting in the bcm43xx device may be the cause of this
difficulty. If my laptop would suspend/resume correctly, then I could test various fixes based on
that hypothesis. Since it does not, I think the band-aid approach is warranted. A proper fix is
still on my agenda; however, getting full data rates still has priority.
Larry
next prev parent reply other threads:[~2007-02-07 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 17:39 [PATCH] bcm43xx: Fix for oops on resume Larry Finger
[not found] ` <45c8bd59.oamnvaNRMZvKoPBa%Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2007-02-07 12:15 ` Johannes Berg
2007-02-07 13:23 ` Larry Finger [this message]
[not found] ` <45C9D2E1.7040906-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2007-02-07 13:32 ` Johannes Berg
[not found] ` <1170855150.6798.38.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-02-07 13:50 ` Larry Finger
[not found] ` <45C9D930.5010307-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2007-02-07 13:54 ` Johannes Berg
2007-02-07 13:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C9D2E1.7040906@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).