From: Timur Tabi <timur@freescale.com>
To: Li Yang-r58472 <LeoLi@freescale.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa
Date: Thu, 08 Feb 2007 07:27:43 -0600 [thread overview]
Message-ID: <45CB254F.9010602@freescale.com> (raw)
In-Reply-To: <989B956029373F45A0B8AF02970818900D43E9@zch01exm26.fsl.freescale.net>
Li Yang-r58472 wrote:
> No, we don't know if the BD ring is in MURAM or main memory as it is
> configurable. iopa() is best choice to handle both case, IMHO.
The above code would only be used if the BD is in MURAM. The "if
bd_mem_part == MEM_PART_MURAM" would stay.
If the BD ring can be in main memory, then I don't think we should be
using a function called "iopa" to get its physical address. It's
conceivable that one day, iopa() will only work on memory that's been
ioremap'ed.
next prev parent reply other threads:[~2007-02-08 13:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 11:31 [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa Li Yang
2007-02-06 14:26 ` Kumar Gala
2007-02-07 9:34 ` Li Yang-r58472
2007-02-07 16:36 ` Kumar Gala
2007-02-07 16:43 ` Timur Tabi
2007-02-07 16:49 ` Kumar Gala
2007-02-07 17:03 ` Timur Tabi
2007-02-08 5:52 ` Li Yang-r58472
2007-02-08 5:57 ` Kumar Gala
2007-02-08 6:48 ` Li Yang-r58472
2007-02-08 6:53 ` Kumar Gala
2007-02-08 7:06 ` Li Yang-r58472
2007-02-08 7:16 ` Kumar Gala
2007-02-08 7:36 ` Li Yang-r58472
2007-02-08 7:41 ` Kumar Gala
2007-02-08 13:35 ` Timur Tabi
2007-02-09 17:22 ` Dan Malek
2007-02-09 17:26 ` Timur Tabi
2007-02-08 13:27 ` Timur Tabi [this message]
2007-02-07 0:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CB254F.9010602@freescale.com \
--to=timur@freescale.com \
--cc=LeoLi@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).