From: Timur Tabi <timur@freescale.com>
To: Dan Malek <dan@embeddedalley.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
netdev@vger.kernel.org,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa
Date: Fri, 09 Feb 2007 11:26:35 -0600 [thread overview]
Message-ID: <45CCAECB.7030207@freescale.com> (raw)
In-Reply-To: <6BD63E47-4738-4116-8A85-983D4FDCFBB9@embeddedalley.com>
Dan Malek wrote:
>
> On Feb 8, 2007, at 8:35 AM, Timur Tabi wrote:
>
>> That's what the original code did, kinda. It called virt_to_phys() if
>> it is main memory, and it called immrbar_virt_to_phys() if it is MURAM.
>> immrbar_virt_to_phys() did pointer math to extract the physical
>> address.
>
> You've got to be kidding. You created yet another function
> to determine the physical address from a virtual one! LOL!
> Plus, you need logic in the code to first determine which
> one to call? Everyone is OK with this?
The whole point behind the patch that we posted a couple days ago is to get rid
of this function. The patch replaced it with a call to iopa(), but Kumar nack'd
that.
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-02-09 17:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 11:31 [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa Li Yang
2007-02-06 14:26 ` Kumar Gala
2007-02-07 9:34 ` Li Yang-r58472
2007-02-07 16:36 ` Kumar Gala
2007-02-07 16:43 ` Timur Tabi
2007-02-07 16:49 ` Kumar Gala
2007-02-07 17:03 ` Timur Tabi
2007-02-08 5:52 ` Li Yang-r58472
2007-02-08 5:57 ` Kumar Gala
2007-02-08 6:48 ` Li Yang-r58472
2007-02-08 6:53 ` Kumar Gala
2007-02-08 7:06 ` Li Yang-r58472
2007-02-08 7:16 ` Kumar Gala
2007-02-08 7:36 ` Li Yang-r58472
2007-02-08 7:41 ` Kumar Gala
2007-02-08 13:35 ` Timur Tabi
2007-02-09 17:22 ` Dan Malek
2007-02-09 17:26 ` Timur Tabi [this message]
2007-02-08 13:27 ` Timur Tabi
2007-02-07 0:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CCAECB.7030207@freescale.com \
--to=timur@freescale.com \
--cc=dan@embeddedalley.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).