From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joseph Jezak Subject: Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007 Date: Fri, 09 Feb 2007 14:17:09 -0500 Message-ID: <45CCC8B5.3060108@gentoo.org> References: <45cca236.+lL/rsW3DbM3elnk%Larry.Finger@lwfinger.net> <200702091945.25187.mb@bu3sch.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Larry Finger , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, John Linville , Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org To: Michael Buesch Return-path: In-Reply-To: <200702091945.25187.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org > > The specs are unclear at this point: > "Write the value to the offset" > Offset in which register type? PHY Register. I've clarified it in the specs, I think this was said before, I made it worse when I cleaned it up. >> // Initialization >> - if (phy->version == 0) { >> + if (phy->analog == 0) { >> bcm43xx_write16(bcm, 0x03E6, 0x0122); >> } else { >> - if (phy->version >= 2) >> - bcm43xx_write16(bcm, 0x03E6, 0x0040); >> + if (phy->analog >= 2) >> + bcm43xx_write16(bcm, 0x0003, (bcm43xx_read16(bcm, 0x0003) >> + & 0xFFBF) | 0x0040); > > I think here is a specs bug. This is correct. Why do you think it's a specs bug? -Joe - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html