[PATCH] phy devices: use same arg types

[PATCH] phy devices: use same arg types

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

sparse complains about differing types from prototype to
definition, so change the u32 to phy_interface_t:

drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect' redeclared with different type (originally declared at include/linux/phy.h:362) - incompatible argument 5 (different signedness)
drivers/net/phy/phy_device.c:190:19: error: symbol 'phy_attach' redeclared with different type (originally declared at include/linux/phy.h:360) - incompatible argument 4 (different signedness)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/net/phy/phy_device.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2620-pv.orig/drivers/net/phy/phy_device.c
+++ linux-2620-pv/drivers/net/phy/phy_device.c
@@ -139,7 +139,7 @@ void phy_prepare_link(struct phy_device 
  */
 struct phy_device * phy_connect(struct net_device *dev, const char *phy_id,
 		void (*handler)(struct net_device *), u32 flags,
-		u32 interface)
+		phy_interface_t interface)
 {
 	struct phy_device *phydev;
 
@@ -188,7 +188,7 @@ static int phy_compare_id(struct device 
 }
 
 struct phy_device *phy_attach(struct net_device *dev,
-		const char *phy_id, u32 flags, u32 interface)
+		const char *phy_id, u32 flags, phy_interface_t interface)
 {
 	struct bus_type *bus = &mdio_bus_type;
 	struct phy_device *phydev;

Re: [PATCH] phy devices: use same arg types

[Andy Fleming]

On Feb 5, 2007, at 12:44, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> sparse complains about differing types from prototype to
> definition, so change the u32 to phy_interface_t:
>
> drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect'  
> redeclared with different type (originally declared at include/ 
> linux/phy.h:362) - incompatible argument 5 (different signedness)
> drivers/net/phy/phy_device.c:190:19: error: symbol 'phy_attach'  
> redeclared with different type (originally declared at include/ 
> linux/phy.h:360) - incompatible argument 4 (different signedness)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>


Acked-by: Andy Fleming <afleming@freescale.com>


Oops,  I thought I had fixed that before submission.


> ---
>  drivers/net/phy/phy_device.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2620-pv.orig/drivers/net/phy/phy_device.c
> +++ linux-2620-pv/drivers/net/phy/phy_device.c
> @@ -139,7 +139,7 @@ void phy_prepare_link(struct phy_device
>   */
>  struct phy_device * phy_connect(struct net_device *dev, const char  
> *phy_id,
>  		void (*handler)(struct net_device *), u32 flags,
> -		u32 interface)
> +		phy_interface_t interface)
>  {
>  	struct phy_device *phydev;
>
> @@ -188,7 +188,7 @@ static int phy_compare_id(struct device
>  }
>
>  struct phy_device *phy_attach(struct net_device *dev,
> -		const char *phy_id, u32 flags, u32 interface)
> +		const char *phy_id, u32 flags, phy_interface_t interface)
>  {
>  	struct bus_type *bus = &mdio_bus_type;
>  	struct phy_device *phydev;
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] phy devices: use same arg types

[Jeff Garzik]

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> sparse complains about differing types from prototype to
> definition, so change the u32 to phy_interface_t:
> 
> drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect' redeclared with different type (originally declared at include/linux/phy.h:362) - incompatible argument 5 (different signedness)
> drivers/net/phy/phy_device.c:190:19: error: symbol 'phy_attach' redeclared with different type (originally declared at include/linux/phy.h:360) - incompatible argument 4 (different signedness)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/net/phy/phy_device.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

applied