netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Mike Accetta <maccetta@laurelnetworks.com>, netdev@vger.kernel.org
Subject: Re: 2.6.20 crash in tcp_tso_segment()
Date: Tue, 13 Feb 2007 15:34:43 +0100	[thread overview]
Message-ID: <45D1CC83.8080603@trash.net> (raw)
In-Reply-To: <E1HFc6X-0006n7-00@gondolin.me.apana.org.au>

Herbert Xu wrote:
> Mike Accetta <maccetta@laurelnetworks.com> wrote:
> 
>>Obviously the code believes it can assume that there are always multiple
>>sk_buff's in the chain.  The stack trace seems to implicate iptables in
>>the scenario (twice) if that means anything.  Any ideas about what may
>>be going wrong here?  There is indeed a private module loaded at the time
>>but it does no networking and I doubt it is the culprit.
> 
> 
> Yeah we should never get here if we only have one segment.
> Could you get it to print out the value of skb->gso_*?

The callpath shows the REJECT target sending a TCP reset.
I'm guessing it has something to do with skb_copy_expand
copying the gso fields.


  reply	other threads:[~2007-02-13 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09  5:57 2.6.20 crash in tcp_tso_segment() Mike Accetta
2007-02-09 20:12 ` Herbert Xu
2007-02-13 14:34   ` Patrick McHardy [this message]
2007-02-13 16:18     ` Mike Accetta
2007-02-13 17:51     ` Herbert Xu
2007-02-13 20:34       ` David Miller
2007-02-13 21:51         ` Herbert Xu
2007-02-13 21:53           ` David Miller
2007-02-14 16:27       ` Mike Accetta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D1CC83.8080603@trash.net \
    --to=kaber@trash.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=maccetta@laurelnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).