* [PATCH] fix atl1 braino
@ 2007-02-13 7:12 Al Viro
2007-02-13 17:21 ` Chris Snook
2007-02-13 17:36 ` Chuck Ebbert
0 siblings, 2 replies; 3+ messages in thread
From: Al Viro @ 2007-02-13 7:12 UTC (permalink / raw)
To: Linus Torvalds; +Cc: netdev, linux-kernel, Jeff Garzik
Spot the bug...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
index 08b2d78..e28707a 100644
--- a/drivers/net/atl1/atl1_hw.c
+++ b/drivers/net/atl1/atl1_hw.c
@@ -357,7 +357,7 @@ void atl1_hash_set(struct atl1_hw *hw, u32 hash_value)
*/
hash_reg = (hash_value >> 31) & 0x1;
hash_bit = (hash_value >> 26) & 0x1F;
- mta = ioread32((hw + REG_RX_HASH_TABLE) + (hash_reg << 2));
+ mta = ioread32((hw->hw_addr + REG_RX_HASH_TABLE) + (hash_reg << 2));
mta |= (1 << hash_bit);
iowrite32(mta, (hw->hw_addr + REG_RX_HASH_TABLE) + (hash_reg << 2));
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fix atl1 braino
2007-02-13 7:12 [PATCH] fix atl1 braino Al Viro
@ 2007-02-13 17:21 ` Chris Snook
2007-02-13 17:36 ` Chuck Ebbert
1 sibling, 0 replies; 3+ messages in thread
From: Chris Snook @ 2007-02-13 17:21 UTC (permalink / raw)
To: Al Viro
Cc: Linus Torvalds, netdev, linux-kernel, Jeff Garzik, Jay Cliburn,
atl1-devel
Al Viro wrote:
> Spot the bug...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>
> diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
> index 08b2d78..e28707a 100644
> --- a/drivers/net/atl1/atl1_hw.c
> +++ b/drivers/net/atl1/atl1_hw.c
> @@ -357,7 +357,7 @@ void atl1_hash_set(struct atl1_hw *hw, u32 hash_value)
> */
> hash_reg = (hash_value >> 31) & 0x1;
> hash_bit = (hash_value >> 26) & 0x1F;
> - mta = ioread32((hw + REG_RX_HASH_TABLE) + (hash_reg << 2));
> + mta = ioread32((hw->hw_addr + REG_RX_HASH_TABLE) + (hash_reg << 2));
> mta |= (1 << hash_bit);
> iowrite32(mta, (hw->hw_addr + REG_RX_HASH_TABLE) + (hash_reg << 2));
> }
ACK.
Thanks for catching this.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix atl1 braino
2007-02-13 7:12 [PATCH] fix atl1 braino Al Viro
2007-02-13 17:21 ` Chris Snook
@ 2007-02-13 17:36 ` Chuck Ebbert
1 sibling, 0 replies; 3+ messages in thread
From: Chuck Ebbert @ 2007-02-13 17:36 UTC (permalink / raw)
To: Al Viro; +Cc: Linus Torvalds, netdev, linux-kernel, Jeff Garzik
Al Viro wrote:
> Spot the bug...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>
> diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
> index 08b2d78..e28707a 100644
> --- a/drivers/net/atl1/atl1_hw.c
> +++ b/drivers/net/atl1/atl1_hw.c
> @@ -357,7 +357,7 @@ void atl1_hash_set(struct atl1_hw *hw, u32 hash_value)
> */
> hash_reg = (hash_value >> 31) & 0x1;
> hash_bit = (hash_value >> 26) & 0x1F;
> - mta = ioread32((hw + REG_RX_HASH_TABLE) + (hash_reg << 2));
> + mta = ioread32((hw->hw_addr + REG_RX_HASH_TABLE) + (hash_reg << 2));
> mta |= (1 << hash_bit);
> iowrite32(mta, (hw->hw_addr + REG_RX_HASH_TABLE) + (hash_reg << 2));
> }
The comment above is funny:
349 /*
350 * The HASH Table is a register array of 2 32-bit registers.
351 * It is treated like an array of 64 bits. We want to set
352 * bit BitArray[hash_value]. So we figure out what register
353 * the bit is in, read it, OR in the new bit, then write
354 * back the new value. The register is determined by the
355 * upper 7 bits of the hash value and the bit within that
356 * register are determined by the lower 5 bits of the value.
How can you use seven bits to choose between two registers?
And they're not using the lower 5 bits, but rather bits 30..26.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-13 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-13 7:12 [PATCH] fix atl1 braino Al Viro
2007-02-13 17:21 ` Chris Snook
2007-02-13 17:36 ` Chuck Ebbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).