netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elad Lahav <elad_lahav@users.sourceforge.net>
To: netdev@vger.kernel.org
Subject: ip_append_page and the socket send buffer
Date: Fri, 16 Feb 2007 15:02:53 -0500	[thread overview]
Message-ID: <45D60DED.7050709@users.sourceforge.net> (raw)

I wrote a function that is equivalent to udp_sendmsg, but uses 
ip_append_page to attach data to an skb. The function is implemented as 
follows:

1. Allocate a page and copy the given data to that page
2. Set up routing and cork the socket
3. Call ip_append_data to create an initial skb (with data length set to 0)
4. Call ip_append_page with the allocated page
5. Call udp_push_pending_frames to send the packet

The function works correctly. Packets are generated and sent as 
expected: this was verified by looking at the packet contents on the 
receiving machine.
However, under load, there is a significant difference in the behaviour 
of udp_sendmsg, compared with my function. The problem is that the 
socket send buffer (wmem_alloc) quickly grows beyond its upper limit 
(which is 131071 by default). This results in numerous failures of 
ip_append_data with EAGAIN, degrading performance considerably.
udp_sendmsg, on the other hand, keeps wmem_alloc in a much smaller range 
under the same load.

Two notes:
1. Modifying the upper limit to 524287 solved the problem completely 
(regardless of the load)
2. The same thing happens with multiple calls to ip_append_data (e.g., 
if I want to copy the data in two sections), so it is not a problem with 
ip_append_page. This leads me o believe that the problem lies with 
Scatter/Gather I/O.

Any thoughts?

Elad

             reply	other threads:[~2007-02-16 20:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 20:02 Elad Lahav [this message]
2007-02-16 21:27 ` ip_append_page and the socket send buffer James Morris
2007-02-16 22:00   ` Elad Lahav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D60DED.7050709@users.sourceforge.net \
    --to=elad_lahav@users.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).