From: Auke Kok <auke-jan.h.kok@intel.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, "Brandeburg,
Jesse" <jesse.brandeburg@intel.com>,
"Kok, Auke" <auke@foo-projects.org>,
"Ronciak, John" <john.ronciak@intel.com>
Subject: Re: [PATCH 1/3] e1000: fix shared interrupt warning message
Date: Sat, 17 Feb 2007 18:20:33 -0800 [thread overview]
Message-ID: <45D7B7F1.8020504@intel.com> (raw)
In-Reply-To: <20070217231949.GB17396@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Auke Kok <auke-jan.h.kok@intel.com> :
> [...]
>> It is suspected that workarounds in the _up() routine of e1000 can cause
> ^^^^^^^^^
>> the receive unit to be enabled before we're all done initializing the
>> adapter data. An interrupt arriving before we're all done setting up
>> obviously causes problems. To fix, we postpone enabling interrupts
>> completely until the software intialization is finished.
>
> Call me dense but is there a chance that the same receive unit that should
> not be enabled now emits interrupts between e1000_up() and request_irq() ?
turning on the receive unit starts the rx logic on the mac, but doesn't make the
mac generate interrupts as far as I know. The fix was verified and even
suggested earlier by some people as well.
Cheers,
Auke
next prev parent reply other threads:[~2007-02-18 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 22:39 [PATCH 0/3] e1000: fix, two minor updates Kok, Auke
2007-02-16 22:39 ` [PATCH 1/3] e1000: fix shared interrupt warning message Kok, Auke
2007-02-17 20:38 ` Jeff Garzik
2007-02-17 20:47 ` Auke Kok
2007-02-17 23:19 ` Francois Romieu
2007-02-18 2:20 ` Auke Kok [this message]
2007-02-16 22:39 ` [PATCH 2/3] e1000: remove obsolete custom pci_save_state code Kok, Auke
2007-02-16 22:39 ` [PATCH 3/3] e1000: allow ethtool to see link status when down Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D7B7F1.8020504@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=auke@foo-projects.org \
--cc=jeff@garzik.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).