netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/3] forcedeth: disable msix
@ 2007-02-19 14:28 Ayaz Abdulla
  2007-02-20 16:26 ` Jeff Garzik
  0 siblings, 1 reply; 4+ messages in thread
From: Ayaz Abdulla @ 2007-02-19 14:28 UTC (permalink / raw)
  To: Jeff Garzik, Manfred Spraul, Andrew Morton, nedev

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

There seems to be an issue when both MSI-X is enabled and NAPI is 
configured. This patch disables MSI-X until the issue is root caused.

Signed-Off-By: Ayaz Abdulla <aabdulla@nvidia.com>


[-- Attachment #2: patch-forcedeth-msix --]
[-- Type: text/plain, Size: 308 bytes --]

--- orig/drivers/net/forcedeth.c	2007-02-19 09:17:02.000000000 -0500
+++ new/drivers/net/forcedeth.c	2007-02-19 09:17:07.000000000 -0500
@@ -839,7 +839,7 @@
 	NV_MSIX_INT_DISABLED,
 	NV_MSIX_INT_ENABLED
 };
-static int msix = NV_MSIX_INT_ENABLED;
+static int msix = NV_MSIX_INT_DISABLED;
 
 /*
  * DMA 64bit

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] forcedeth: disable msix
@ 2007-02-20  8:34 Ayaz Abdulla
  2007-02-23 20:20 ` Andy Gospodarek
  0 siblings, 1 reply; 4+ messages in thread
From: Ayaz Abdulla @ 2007-02-20  8:34 UTC (permalink / raw)
  To: Jeff Garzik, Manfred Spraul, Andrew Morton, nedev

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

There seems to be an issue when both MSI-X is enabled and NAPI is 
configured. This patch disables MSI-X until the issue is root caused.

Signed-Off-By: Ayaz Abdulla <aabdulla@nvidia.com>


[-- Attachment #2: patch-forcedeth-msix --]
[-- Type: text/plain, Size: 308 bytes --]

--- orig/drivers/net/forcedeth.c	2007-02-20 03:29:04.000000000 -0500
+++ new/drivers/net/forcedeth.c	2007-02-20 03:29:33.000000000 -0500
@@ -839,7 +839,7 @@
 	NV_MSIX_INT_DISABLED,
 	NV_MSIX_INT_ENABLED
 };
-static int msix = NV_MSIX_INT_ENABLED;
+static int msix = NV_MSIX_INT_DISABLED;
 
 /*
  * DMA 64bit

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/3] forcedeth: disable msix
  2007-02-19 14:28 [PATCH 2/3] forcedeth: disable msix Ayaz Abdulla
@ 2007-02-20 16:26 ` Jeff Garzik
  0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-02-20 16:26 UTC (permalink / raw)
  To: Ayaz Abdulla; +Cc: Manfred Spraul, Andrew Morton, nedev

Ayaz Abdulla wrote:
> There seems to be an issue when both MSI-X is enabled and NAPI is 
> configured. This patch disables MSI-X until the issue is root caused.
> 
> Signed-Off-By: Ayaz Abdulla <aabdulla@nvidia.com>

ACK patches 2-3

Will await resend of entire patch series, after patch #1 is updated



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/3] forcedeth: disable msix
  2007-02-20  8:34 Ayaz Abdulla
@ 2007-02-23 20:20 ` Andy Gospodarek
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Gospodarek @ 2007-02-23 20:20 UTC (permalink / raw)
  To: Ayaz Abdulla; +Cc: Jeff Garzik, Manfred Spraul, Andrew Morton, nedev

On Tue, Feb 20, 2007 at 03:34:40AM -0500, Ayaz Abdulla wrote:
> There seems to be an issue when both MSI-X is enabled and NAPI is 
> configured. This patch disables MSI-X until the issue is root caused.
> 
> Signed-Off-By: Ayaz Abdulla <aabdulla@nvidia.com>
> 

> --- orig/drivers/net/forcedeth.c	2007-02-20 03:29:04.000000000 -0500
> +++ new/drivers/net/forcedeth.c	2007-02-20 03:29:33.000000000 -0500
> @@ -839,7 +839,7 @@
>  	NV_MSIX_INT_DISABLED,
>  	NV_MSIX_INT_ENABLED
>  };
> -static int msix = NV_MSIX_INT_ENABLED;
> +static int msix = NV_MSIX_INT_DISABLED;
>  
>  /*
>   * DMA 64bit


Ayaz,

Can you elaborate on symptoms that would make one want to use this
patch?

-andy



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-02-23 20:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-19 14:28 [PATCH 2/3] forcedeth: disable msix Ayaz Abdulla
2007-02-20 16:26 ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2007-02-20  8:34 Ayaz Abdulla
2007-02-23 20:20 ` Andy Gospodarek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).