From: Auke Kok <auke-jan.h.kok@intel.com>
To: Chris Snook <csnook@redhat.com>
Cc: jeff@garzik.org, jacliburn@bellsouth.net, john.ronciak@intel.com,
jesse.brandeburg@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] remove irq_sem cruft from e1000 and derivatives
Date: Mon, 19 Feb 2007 17:06:26 -0800 [thread overview]
Message-ID: <45DA4992.2070103@intel.com> (raw)
In-Reply-To: <20070220.Bq5.44322700@egw.corp.redhat.com>
Chris Snook wrote:
> Hey folks --
>
> While digging through the atl1 source, I was troubled by the code using
> irq_sem. I did some digging and found the same code in e1000 and ixgb. I'm
> not entirely sure what it was originally intended to do, but it doesn't seem
> to be doing anything useful now, except possibly locking interrupts off if
> NAPI is flipped on and off enough times to cause an integer overflow.
>
> The following patches completely remove irq_sem from each of the drivers.
> This has been tested successfully on atl1 and e1000. If someone would like
> to send me ixgb hardware I'd be glad to test that, otherwise you'll have to
> test it yourself. :)
>
> -- Chris
I'm not yet seeing patches 1/3 appear, but I'll certainly take a look at them
and have them tested in our labs once they appear for e1000 and ixgb.
Cheers,
Auke
next prev parent reply other threads:[~2007-02-20 1:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 0:57 [PATCH 0/3] remove irq_sem cruft from e1000 and derivatives Chris Snook
2007-02-20 1:03 ` [PATCH 1/3] remove irq_sem from atl1 Chris Snook
2007-02-27 9:32 ` Jeff Garzik
2007-02-27 17:28 ` Chris Snook
2007-02-20 1:06 ` Auke Kok [this message]
2007-02-20 1:10 ` [PATCH 2/3] remove irq_sem from e1000 Chris Snook
2007-04-09 17:54 ` Kok, Auke
2007-04-09 20:34 ` Chris Snook
2007-02-20 1:12 ` [PATCH 3/3] remove irq_sem from ixgb Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DA4992.2070103@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=csnook@redhat.com \
--cc=jacliburn@bellsouth.net \
--cc=jeff@garzik.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).