From: Divy Le Ray <divy@chelsio.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] chelsio: Fix non-NAPI compile
Date: Wed, 21 Feb 2007 00:05:58 -0800 [thread overview]
Message-ID: <45DBFD66.7070305@chelsio.com> (raw)
In-Reply-To: <adamz38c55r.fsf@cisco.com>
Roland Dreier wrote:
> Chelsio without NAPI enabled has been broken (won't compile) since
> 3de00b89 ("chelsio: NAPI speed improvement"):
>
> drivers/net/chelsio/sge.c: In function `t1_interrupt`:
> drivers/net/chelsio/sge.c:1716: error: `Q` undeclared (first use in this function)
>
> The change below seems to add back in the declaration and
> initialization of `Q` that was removed by mistake, and at least makes
> the driver compile for me, although I have no hardware and hence no
> way to test whether this actually works.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
>
Roland,
You beat me :)
Cheers,
Divy
> ---
> Hi Stephen, since you seem to be looking after this driver a little
> bit (and since you broke it ;), I'll send this patch to you.
>
> If this seems right to you, please merge it (although perhaps it would
> make more sense just to kill the non-NAPI code, since no one noticed
> it didn't compile).
>
>
> diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c
> index 89a6827..326d4a6 100644
> --- a/drivers/net/chelsio/sge.c
> +++ b/drivers/net/chelsio/sge.c
> @@ -1696,6 +1696,7 @@ irqreturn_t t1_interrupt(int irq, void *cookie)
> {
> int work_done;
> struct adapter *adapter = cookie;
> + struct respQ *Q = &adapter->sge->respQ;
>
> spin_lock(&adapter->async_lock);
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2007-02-21 8:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 23:57 [PATCH 0/3] chelsio 10G driver cleanups Stephen Hemminger
2007-02-20 23:58 ` [PATCH 1/3] chelsio: remove unused code for 1G boards Stephen Hemminger
2007-02-27 9:32 ` Jeff Garzik
2007-02-20 23:58 ` [PATCH 2/3] chelsio: use C99 style initialization Stephen Hemminger
2007-02-20 23:58 ` [PATCH 3/3] chelsio: use const for virtual functions Stephen Hemminger
2007-02-21 7:59 ` [PATCH] chelsio: Fix non-NAPI compile Roland Dreier
2007-02-21 8:05 ` Divy Le Ray [this message]
2007-02-26 22:58 ` [PATCH, RESEND] " Roland Dreier
2007-02-26 23:00 ` Stephen Hemminger
2007-02-27 9:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DBFD66.7070305@chelsio.com \
--to=divy@chelsio.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).