From: Divy Le Ray <divy@chelsio.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@osdl.org, benh@kernel.crashing.org,
netdev@vger.kernel.org, ebs@ebshome.net,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] split NAPI from network device.
Date: Thu, 22 Feb 2007 04:24:35 -0800 [thread overview]
Message-ID: <45DD8B83.5040604@chelsio.com> (raw)
In-Reply-To: <20070220.213125.74747066.davem@davemloft.net>
Hi Dave,
>
> @@ -919,10 +920,7 @@ int dev_close(struct net_device *dev)
> * engine, but this requires more changes in devices. */
>
> smp_mb__after_clear_bit(); /* Commit netif_running(). */
> - while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
> - /* No hurry. */
> - msleep(1);
> - }
> + netif_poll_disable(dev);
When dev_close() exits, NAPI_STATE_SCHED will be set,
whereas __LINK_STATE_RX_SCHED was previously reset.
The cxgb3 driver assumes that the device is not scheduled after the
interface was brought up.
It's no longer true if the interface is brought up, brought down, and
then brought up.
Should cxgb3 explicitly call napi_enable() on the open() path ?
Cheers,
Divy
prev parent reply other threads:[~2007-02-22 12:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 5:27 [PATCH] add init_dummy_netdev() for napi only dummy intefaces Benjamin Herrenschmidt
2006-12-13 19:35 ` Stephen Hemminger
2006-12-13 20:42 ` Benjamin Herrenschmidt
2006-12-13 21:06 ` Stephen Hemminger
2006-12-13 23:46 ` [RFC] split NAPI from network device Stephen Hemminger
2006-12-14 20:01 ` Benjamin Herrenschmidt
2007-02-21 5:31 ` David Miller
2007-02-21 7:39 ` Divy Le Ray
2007-02-21 7:47 ` David Miller
2007-02-21 23:24 ` Benjamin Herrenschmidt
2007-02-22 11:18 ` David Miller
2007-02-22 12:24 ` Divy Le Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DD8B83.5040604@chelsio.com \
--to=divy@chelsio.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=ebs@ebshome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).