From mboxrd@z Thu Jan 1 00:00:00 1970 From: Divy Le Ray Subject: Re: [PATCH 2/7] cxgb3 - private ioctl cleanup Date: Thu, 22 Feb 2007 04:50:05 -0800 Message-ID: <45DD917D.5010807@chelsio.com> References: <20070222115925.10001.61276.stgit@localhost.localdomain> <20070222.210618.134161490.yoshfuji@linux-ipv6.org> <45DD8DDA.8060303@chelsio.com> <20070222.213915.89824941.yoshfuji@linux-ipv6.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: divy@chelsio.com, jeff@garzik.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, swise@opengridcomputing.com, yoshfuji@linux-ipv6.org To: yoshfuji@linux-ipv6.org Return-path: Received: from stargate.chelsio.com ([12.22.49.110]:8407 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750718AbXBVMuX (ORCPT ); Thu, 22 Feb 2007 07:50:23 -0500 In-Reply-To: <20070222.213915.89824941.yoshfuji@linux-ipv6.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org YOSHIFUJI Hideaki / $B5HF#1QL@ wrote: > In article <45DD8DDA.8060303@chelsio.com> (at Thu, 22 Feb 2007 04:34:34 -0800), Divy Le Ray says: > > > >>> 1. Please do do change the values. >>> 2. Explain why you are going to kill these ioctls. >>> >>> >> Jeff and Arjan have required that most of these ioctls go. >> Please read: >> http://marc.theaimsgroup.com/?l=linux-netdev&m=117029584904193&w=2 >> > > Even if you remove them, PLEASE DO NOT CHANGE THE VALUES, > unless you have very, very good reason. > The cxgb3 driver has not yet appeared in a stable version of the linux kernel. The odds of breaking an application using these private ioctls are pretty slim. Since some cleanup was required, I chose not to let holes between the values. Cheers, Divy