From mboxrd@z Thu Jan 1 00:00:00 1970 From: Divy Le Ray Subject: Re: [PATCH 3/7] cxgb3 - FW version update Date: Sun, 25 Feb 2007 16:36:33 -0800 Message-ID: <45E22B91.1060702@chelsio.com> References: <20070225004401.20831.3292.stgit@localhost.localdomain> <1172431719.4717.8.camel@stevo-laptop> <45E1E810.2000706@garzik.org> <1172440758.4717.17.camel@stevo-laptop> <45E21009.6040706@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Steve Wise , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Jeff Garzik Return-path: Received: from stargate.chelsio.com ([12.22.49.110]:18145 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933727AbXBZAiM (ORCPT ); Sun, 25 Feb 2007 19:38:12 -0500 In-Reply-To: <45E21009.6040706@garzik.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Jeff Garzik wrote: > Steve Wise wrote: >>> I would rather fix the code to use constants, and thus avoid this >>> problem ever happening again. >>> >>> Jeff >>> >> >> How's this (not tested)? > > seems OK to me > > I tested it and resubmitted. Thanks fro the fix suggestion and the patch! Cheers, Divy