From: Divy Le Ray <divy@chelsio.com>
To: Christoph Hellwig <hch@infradead.org>,
divy@chelsio.com, jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, swise@opengridcomputing.com
Subject: Re: [PATCH 7/7] cxgb3 - Add SW LRO support
Date: Mon, 26 Feb 2007 16:55:29 -0800 [thread overview]
Message-ID: <45E38181.5030409@chelsio.com> (raw)
In-Reply-To: <20070226051304.GA13626@infradead.org>
Christoph Hellwig wrote:
> On Sat, Feb 24, 2007 at 04:44:23PM -0800, divy@chelsio.com wrote:
>
>> From: Divy Le Ray <divy@chelsio.com>
>>
>> Add all-in-sw lro support.
>>
>
> Doing this in a LLDD doesn't sound like a good idea. Have you
> tried doing this in the core networking code instead?
>
We have not tried to implement LRO in the core networking code.
Today, the available API for a driver to pass packets up is
netif_receive_skb/netif_rx.
Our implementation coalesces pages, then gets a skb to point at the
pages and passes it up to the stack.
LRO in the core networking code would require adding methods to pass up
data segments in addition to skbs.
HW might also be able to assist LRO by identifying the session an
incoming packet belongs to,
thus avoiding the session lookup. The API should also allow for the
driver to indicate such info.
Cheers,
Divy
next prev parent reply other threads:[~2007-02-27 0:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-25 0:44 [PATCH 7/7] cxgb3 - Add SW LRO support divy
2007-02-26 5:13 ` Christoph Hellwig
2007-02-27 0:55 ` Divy Le Ray [this message]
2007-02-27 14:17 ` Steve Wise
2007-02-27 14:53 ` Jeff Garzik
2007-02-27 14:57 ` Steve Wise
2007-02-27 16:29 ` Brice Goglin
2007-06-01 20:37 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-02-22 11:59 divy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E38181.5030409@chelsio.com \
--to=divy@chelsio.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).