From: Jeff Garzik <jeff@garzik.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Dale Farnsworth <dale@farnsworth.org>,
netdev@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [RFC][NET] Alignment in mv643xx_eth
Date: Tue, 27 Feb 2007 04:21:56 -0500 [thread overview]
Message-ID: <45E3F834.70307@garzik.org> (raw)
In-Reply-To: <20070226195206.GA10188@linux-mips.org>
Ralf Baechle wrote:
> The driver contains this little piece of candy:
>
> #if defined(CONFIG_DMA_NONCOHERENT) || defined(CONFIG_NOT_COHERENT_CACHE)
> #define ETH_DMA_ALIGN L1_CACHE_BYTES
> #else
> #define ETH_DMA_ALIGN 8
> #endif
>
> Any reason why we're not using dma_get_cache_alignment() instead?
>
> Ralf
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
applied
prev parent reply other threads:[~2007-02-27 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 19:52 [RFC][NET] Alignment in mv643xx_eth Ralf Baechle
2007-02-26 21:48 ` Dale Farnsworth
2007-02-27 9:21 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E3F834.70307@garzik.org \
--to=jeff@garzik.org \
--cc=dale@farnsworth.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).