From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 7/7] cxgb3 - Add SW LRO support Date: Tue, 27 Feb 2007 09:53:06 -0500 Message-ID: <45E445D2.2090900@garzik.org> References: <20070225004423.20903.17036.stgit@localhost.localdomain> <20070226051304.GA13626@infradead.org> <1172585835.11870.13.camel@stevo-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , divy@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Steve Wise Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:52079 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbXB0Oxj (ORCPT ); Tue, 27 Feb 2007 09:53:39 -0500 In-Reply-To: <1172585835.11870.13.camel@stevo-desktop> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Steve Wise wrote: > On Mon, 2007-02-26 at 05:13 +0000, Christoph Hellwig wrote: >> On Sat, Feb 24, 2007 at 04:44:23PM -0800, divy@chelsio.com wrote: >>> From: Divy Le Ray >>> >>> Add all-in-sw lro support. >> Doing this in a LLDD doesn't sound like a good idea. Have you >> tried doing this in the core networking code instead? > > It looks like both Netxen and Neterion drivers already have this. So I > think for now the LLDD implements LRO. The stack supports it by virtue That's argument to further avoiding compounding the problem, by reinventing the wheel for each driver. Jeff