From: Brice Goglin <brice@myri.com>
To: Jeff Garzik <jeff@garzik.org>, Christoph Hellwig <hch@infradead.org>
Cc: Steve Wise <swise@opengridcomputing.com>,
divy@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] cxgb3 - Add SW LRO support
Date: Tue, 27 Feb 2007 17:29:34 +0100 [thread overview]
Message-ID: <45E45C6E.3000504@myri.com> (raw)
In-Reply-To: <1172588246.11870.24.camel@stevo-desktop>
Steve Wise wrote:
> You're right. But cxgb3 has it now in the driver (tested and working).
> Shouldn't it be pulled in? When the network stack design gets done
> (which could take a few releases to finalize), all the drivers can be
> updated to use it. It doesn't seem reasonable to allow some drivers to
> support LRO and others to not support it...
>
I have to agree with Steve here. We have been requesting the inclusion
of myri10ge LRO for 5 months now (before 2.6.19). I could understand
that duplicating LRO code between s2io and myri10ge was not a good idea
at this point. But, I now see that Netxen got merged way later (in
2.6.20) but it got its LRO merged immediately. I guess the LRO is
already duplicated between s2io and netxen then. It does not look fair
to me at all.
Thank you for understanding our concerns.
Brice
next prev parent reply other threads:[~2007-02-27 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-25 0:44 [PATCH 7/7] cxgb3 - Add SW LRO support divy
2007-02-26 5:13 ` Christoph Hellwig
2007-02-27 0:55 ` Divy Le Ray
2007-02-27 14:17 ` Steve Wise
2007-02-27 14:53 ` Jeff Garzik
2007-02-27 14:57 ` Steve Wise
2007-02-27 16:29 ` Brice Goglin [this message]
2007-06-01 20:37 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-02-22 11:59 divy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E45C6E.3000504@myri.com \
--to=brice@myri.com \
--cc=divy@chelsio.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).