From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
paul.moore@hp.com
Subject: [NET]: Fix kfree(skb)
Date: Tue, 27 Feb 2007 18:06:32 +0100 [thread overview]
Message-ID: <45E46518.5070100@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1914 bytes --]
[NET]: Fix kfree(skb)
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit ddab8d6f231e068c78fb6b1a987a576bc81363f9
tree f724269dd5ac7f125159614ce4482b1b98a5192f
parent 01363220f5d23ef68276db8974e46a502e43d01d
author Patrick McHardy <kaber@trash.net> Tue, 27 Feb 2007 18:02:52 +0100
committer Patrick McHardy <kaber@trash.net> Tue, 27 Feb 2007 18:02:52 +0100
net/core/skbuff.c | 2 +-
net/dccp/output.c | 2 +-
net/netlabel/netlabel_unlabeled.c | 2 +-
net/xfrm/xfrm_user.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f89ff15..820761f 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2037,7 +2037,7 @@ struct sk_buff *skb_segment(struct sk_bu
err:
while ((skb = segs)) {
segs = skb->next;
- kfree(skb);
+ kfree_skb(skb);
}
return ERR_PTR(err);
}
diff --git a/net/dccp/output.c b/net/dccp/output.c
index f5c6aca..3282f2f 100644
--- a/net/dccp/output.c
+++ b/net/dccp/output.c
@@ -269,7 +269,7 @@ void dccp_write_xmit(struct sock *sk, in
err);
} else {
dccp_pr_debug("packet discarded\n");
- kfree(skb);
+ kfree_skb(skb);
}
}
}
diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c
index 5bc3718..b931ede 100644
--- a/net/netlabel/netlabel_unlabeled.c
+++ b/net/netlabel/netlabel_unlabeled.c
@@ -173,7 +173,7 @@ static int netlbl_unlabel_list(struct sk
return 0;
list_failure:
- kfree(ans_skb);
+ kfree_skb(ans_skb);
return ret_val;
}
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 2567453..3e66b55 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -1401,7 +1401,7 @@ static int xfrm_get_ae(struct sk_buff *s
x = xfrm_state_lookup(&id->daddr, id->spi, id->proto, id->family);
if (x == NULL) {
- kfree(r_skb);
+ kfree_skb(r_skb);
return -ESRCH;
}
next reply other threads:[~2007-02-27 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 17:06 Patrick McHardy [this message]
2007-02-27 17:35 ` [NET]: Fix kfree(skb) Paul Moore
2007-02-27 18:00 ` David Miller
2007-02-27 18:14 ` Evgeniy Polyakov
2007-02-27 18:20 ` Evgeniy Polyakov
2007-02-27 18:24 ` David Miller
2007-02-27 22:24 ` Arnaldo Carvalho de Melo
2007-02-28 9:02 ` Run-time kfree check for correct cache [was Re: [NET]: Fix kfree(skb)] Evgeniy Polyakov
2007-02-28 10:10 ` Eric Dumazet
2007-02-28 14:16 ` Run-time kfree check for correct cache [plus x86_64 APIC troubles] Evgeniy Polyakov
2007-03-01 16:17 ` Additional run-tme check [Run-time kfree check for correct cache] Evgeniy Polyakov
2007-02-27 18:01 ` [NET]: Fix kfree(skb) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E46518.5070100@trash.net \
--to=kaber@trash.net \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).