Re: [PATCH 2/4]: Store retransmit queue packets in RB tree.

[Eric Dumazet <dada1@cosmosbay.com>]

David Miller a écrit :
> commit c387760826bd71103220e06ca7b0bf90a785567e
> Author: David S. Miller <davem@sunset.davemloft.net>
> Date:   Tue Feb 27 16:44:42 2007 -0800
> 
>     [TCP]: Store retransmit queue packets in RB tree.
>     
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 4ff3940..b70fd21 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -18,6 +18,7 @@
>  #include <linux/compiler.h>
>  #include <linux/time.h>
>  #include <linux/cache.h>
> +#include <linux/rbtree.h>
>  
>  #include <asm/atomic.h>
>  #include <asm/types.h>
> @@ -232,6 +233,8 @@ struct sk_buff {
>  	struct sk_buff		*next;
>  	struct sk_buff		*prev;
>  
> +	struct rb_node		rb;
> +
>  	struct sock		*sk;
>  	struct skb_timeval	tstamp;
>  	struct net_device	*dev;


I am not sure this rb_node placement is optimal. rb lookups want to access 
rb_node and end_seq. They should be placed in the same cache line :)

next/prev were at the begining of sk_buff, there is no such constraint for rb