* [PATCH 2/3] bonding: only receive ARPs for us
@ 2007-03-01 1:03 Jay Vosburgh
2007-03-03 1:26 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Jay Vosburgh @ 2007-03-01 1:03 UTC (permalink / raw)
To: netdev, bonding-devel; +Cc: Jeff Garzik
The ARP validation code only needs ARPs for the bonding device.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 1f263ac..7ec6121 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -3427,7 +3427,7 @@ void bond_register_arp(struct bonding *b
return;
pt->type = htons(ETH_P_ARP);
- pt->dev = NULL; /*bond->dev;XXX*/
+ pt->dev = bond->dev;
pt->func = bond_arp_rcv;
dev_add_pack(pt);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] bonding: only receive ARPs for us
2007-03-01 1:03 [PATCH 2/3] bonding: only receive ARPs for us Jay Vosburgh
@ 2007-03-03 1:26 ` Jeff Garzik
2007-03-03 1:38 ` [Bonding-devel] " Jay Vosburgh
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-03-03 1:26 UTC (permalink / raw)
To: Jay Vosburgh; +Cc: netdev, bonding-devel
Jay Vosburgh wrote:
> The ARP validation code only needs ARPs for the bonding device.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
I seem to have lost the context of this. Did this get discussed, and
need further revision?
The three patches from 2/28/2007 look OK to me, and I just wanted to
make sure before applying them.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bonding-devel] [PATCH 2/3] bonding: only receive ARPs for us
2007-03-03 1:26 ` Jeff Garzik
@ 2007-03-03 1:38 ` Jay Vosburgh
2007-03-03 1:41 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Jay Vosburgh @ 2007-03-03 1:38 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, bonding-devel
Jeff Garzik <jeff@garzik.org> wrote:
>Jay Vosburgh wrote:
>> The ARP validation code only needs ARPs for the bonding device.
>>
>> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
>
>I seem to have lost the context of this. Did this get discussed, and
>need further revision?
The further discussion can be (loosely) paraphrased as:
Andy Gospodarek <andy@greyhouse.net>: "Hey, this no workee with IPv6."
Me: "True, but bonding no workee with IPv6 at all."
Andy: "Oh, ok. Ack."
After which followed some preliminary yakkage about fixing up
said non-workee IPv6 support.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bonding-devel] [PATCH 2/3] bonding: only receive ARPs for us
2007-03-03 1:38 ` [Bonding-devel] " Jay Vosburgh
@ 2007-03-03 1:41 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-03-03 1:41 UTC (permalink / raw)
To: Jay Vosburgh; +Cc: netdev, bonding-devel
Jay Vosburgh wrote:
> Jeff Garzik <jeff@garzik.org> wrote:
>
>> Jay Vosburgh wrote:
>>> The ARP validation code only needs ARPs for the bonding device.
>>>
>>> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
>> I seem to have lost the context of this. Did this get discussed, and
>> need further revision?
>
> The further discussion can be (loosely) paraphrased as:
>
> Andy Gospodarek <andy@greyhouse.net>: "Hey, this no workee with IPv6."
>
> Me: "True, but bonding no workee with IPv6 at all."
>
> Andy: "Oh, ok. Ack."
>
> After which followed some preliminary yakkage about fixing up
> said non-workee IPv6 support.
thanks :) I'll make sure the 3 patches go into #upstream-fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-03 1:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-01 1:03 [PATCH 2/3] bonding: only receive ARPs for us Jay Vosburgh
2007-03-03 1:26 ` Jeff Garzik
2007-03-03 1:38 ` [Bonding-devel] " Jay Vosburgh
2007-03-03 1:41 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).