From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org
Subject: Re: [patch 11/19] sis900 warning fixes
Date: Tue, 06 Mar 2007 06:15:47 -0500 [thread overview]
Message-ID: <45ED4D63.5030901@garzik.org> (raw)
In-Reply-To: <200703061041.l26AftIO019765@shell0.pdx.osdl.net>
akpm@linux-foundation.org wrote:
> diff -puN drivers/net/sis900.c~sis900-warning-fixes drivers/net/sis900.c
> --- a/drivers/net/sis900.c~sis900-warning-fixes
> +++ a/drivers/net/sis900.c
> @@ -1430,7 +1430,7 @@ static void sis900_auto_negotiate(struct
> int i = 0;
> u32 status;
>
> - while (i++ < 2)
> + for (i = 0; i < 2; i++)
> status = mdio_read(net_dev, phy_addr, MII_STATUS);
>
> if (!(status & MII_STAT_LINK)){
applied, though, you missed killing a redundant initialization
prev parent reply other threads:[~2007-03-06 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 10:41 [patch 11/19] sis900 warning fixes akpm
2007-03-06 11:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED4D63.5030901@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).