From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, giri@lmc.cs.sunysb.edu,
dale@farnsworth.org, pgiri@yahoo.com
Subject: Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix
Date: Tue, 06 Mar 2007 06:16:43 -0500 [thread overview]
Message-ID: <45ED4D9B.9090100@garzik.org> (raw)
In-Reply-To: <200703061042.l26Ag25d019787@shell0.pdx.osdl.net>
akpm@linux-foundation.org wrote:
> From: Giridhar Pemmasani <giri@lmc.cs.sunysb.edu>
>
> During initialization, mv643xx driver registers IRQ before setting up tx/rx
> rings. This causes kernel oops because mv643xx_poll, which gets called
> right after registering IRQ, calls netif_rx_complete, which accesses the rx
> ring (I don't have the oops message anymore; I just remember this sequence
> of calls). Attached (tested) patch first initializes the rx/tx rings and
> then registers the IRQ.
>
> Signed-off-by: Giridhar Pemmasani <pgiri@yahoo.com>
> Cc: Dale Farnsworth <dale@farnsworth.org>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/mv643xx_eth.c | 40 +++++++++++++++++++-----------------
> 1 file changed, 22 insertions(+), 18 deletions(-)
seems sane enough to me, but I would like to get this via Dale, who has
been a fairly active maintainer so far
next prev parent reply other threads:[~2007-03-06 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 10:42 [patch 18/19] mv643xx ethernet driver IRQ registration fix akpm
2007-03-06 11:16 ` Jeff Garzik [this message]
2007-03-06 16:46 ` Dale Farnsworth
2007-03-06 17:35 ` Giridhar Pemmasani
2007-03-08 0:05 ` Giridhar Pemmasani
2007-03-08 5:21 ` [PATCH] mv643xx: Clear pending interrupts before calling request_irq Dale Farnsworth
2007-03-09 16:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED4D9B.9090100@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=dale@farnsworth.org \
--cc=giri@lmc.cs.sunysb.edu \
--cc=netdev@vger.kernel.org \
--cc=pgiri@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).