From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, shanlu@cs.uiuc.edu
Subject: Re: [patch 19/19] network: add the missing phy_device speed information to phy_mii_ioctl
Date: Tue, 06 Mar 2007 06:21:20 -0500 [thread overview]
Message-ID: <45ED4EB0.9010802@garzik.org> (raw)
In-Reply-To: <200703061042.l26Ag3q4019790@shell0.pdx.osdl.net>
akpm@linux-foundation.org wrote:
> From: "Shan Lu" <shanlu@cs.uiuc.edu>
>
> Function `phy_mii_ioctl' returns physical device's information based on
> user requests. When requested to return the basic mode control register
> information (BMCR), the original implementation only returns the physical
> device's duplex information and forgets to return speed information, which
> should not be because BMCR register is used to hold both duplex and speed
> information.
>
> The patch checks the BMCR value against speed-related flags and fills the
> return structure's speed field accordingly.
>
> Signed-off-by: Shan <shanlu@cs.uiuc.edu>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/phy/phy.c | 6 ++++++
> 1 file changed, 6 insertions(+)
applied
prev parent reply other threads:[~2007-03-06 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 10:42 [patch 19/19] network: add the missing phy_device speed information to phy_mii_ioctl akpm
2007-03-06 11:21 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED4EB0.9010802@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shanlu@cs.uiuc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).