From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution
Date: Thu, 08 Mar 2007 17:45:16 +0100 [thread overview]
Message-ID: <45F03D9C.6050708@trash.net> (raw)
In-Reply-To: <200703081742.11720.dada1@cosmosbay.com>
Eric Dumazet wrote:
> On Thursday 08 March 2007 17:28, Patrick McHardy wrote:
>>>--- a/include/asm-mips/sockios.h
>>>+++ b/include/asm-mips/sockios.h
>>>@@ -20,6 +20,7 @@ #define SIOCATMARK _IOR('s', 7, int)
>>> #define SIOCSPGRP _IOW('s', 8, pid_t)
>>> #define SIOCGPGRP _IOR('s', 9, pid_t)
>>>
>>>-#define SIOCGSTAMP 0x8906 /* Get stamp - linux-specific */
>>>+#define SIOCGSTAMP 0x8906 /* Get stamp (timeval) */
>>>+#define SIOCGSTAMPNS 0x8907 /* Get stamp (timespec) */
>>
>>You might want to CC linux-arch or the architecture maintainers.
>>Last time I changed something in this area I got complaints
>>because it affected syscall emulation for non-Linux binaries
>>or something like that.
>
>
> I really dont see how this change could break syscall emulation for non-Linux
> binaries. SIOCGSTAMP{NS} is linux specific.
>
> Could you please give the context of your past problems ?
It was when I added the SO_SNDBUFFORCE/SO_RCVBUFFORCE setsockopt
options. IIRC the values I chose where already used differently
for non-Linux MIPS binaries.
next prev parent reply other threads:[~2007-03-08 16:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 10:18 CLOCK_MONOTONIC datagram timestamps by the kernel John
2007-02-28 13:37 ` John
2007-02-28 13:55 ` Eric Dumazet
2007-02-28 14:23 ` John
2007-02-28 14:55 ` Eric Dumazet
2007-02-28 16:07 ` John
2007-03-01 10:03 ` Evgeniy Polyakov
2007-03-01 11:30 ` Eric Dumazet
2007-03-01 15:54 ` Stephen Hemminger
2007-03-01 16:13 ` Eric Dumazet
2007-03-02 14:38 ` [PATCH] NET : convert network timestamps to ktime_t Eric Dumazet
2007-03-02 16:27 ` Stephen Hemminger
2007-03-02 21:02 ` Stephen Hemminger
2007-03-02 22:46 ` Eric Dumazet
2007-03-05 0:19 ` David Miller
2007-03-05 6:56 ` Eric Dumazet
2007-03-05 7:40 ` Eric Dumazet
2007-03-05 8:00 ` David Miller
2007-03-05 8:21 ` Eric Dumazet
2007-03-05 8:49 ` David Miller
2007-03-08 14:17 ` [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution Eric Dumazet
2007-03-08 16:28 ` Patrick McHardy
2007-03-08 16:42 ` Eric Dumazet
2007-03-08 16:45 ` Patrick McHardy [this message]
2007-03-09 4:39 ` David Miller
2007-03-09 18:39 ` [PATCH] NET : Adding SO_TIMESTAMPNS / SCM_TIMESTAMPNS support Eric Dumazet
2007-03-09 22:17 ` David Miller
2007-03-01 18:53 ` CLOCK_MONOTONIC datagram timestamps by the kernel Stephen Hemminger
2007-03-01 23:14 ` Eric Dumazet
2007-03-01 23:34 ` Stephen Hemminger
2007-03-02 0:56 ` Eric Dumazet
2007-03-02 9:26 ` John
2007-03-02 10:11 ` Eric Dumazet
2007-02-28 18:22 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F03D9C.6050708@trash.net \
--to=kaber@trash.net \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).