* Re: [PATCH 0/2] NET: Multiple queue network device support REPOST [not found] <1173420779298-git-send-email-peter.p.waskiewicz.jr@intel.com> @ 2007-03-09 6:21 ` David Miller 2007-03-09 6:42 ` Waskiewicz Jr, Peter P 2007-03-09 6:45 ` Kok, Auke 0 siblings, 2 replies; 6+ messages in thread From: David Miller @ 2007-03-09 6:21 UTC (permalink / raw) To: peter.p.waskiewicz.jr; +Cc: netdev, linux-kernel, christopher.leech You didn't address my correction the other day wherein I clarified for you that my idea was not to store the queue mapping in skb->priority but rather to shrink skb->priority to a u16 and add a new u16 skb->queue_mapping or whatever field to store the necessary information. You're just posting a set of patches using the same approach again plus some bug fixes, so there is essentially nothing new for anyone to review. Why ask for feedback if you fail to take any of it into consideration? :-/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 0/2] NET: Multiple queue network device support REPOST 2007-03-09 6:21 ` [PATCH 0/2] NET: Multiple queue network device support REPOST David Miller @ 2007-03-09 6:42 ` Waskiewicz Jr, Peter P 2007-03-09 7:11 ` David Miller 2007-03-09 6:45 ` Kok, Auke 1 sibling, 1 reply; 6+ messages in thread From: Waskiewicz Jr, Peter P @ 2007-03-09 6:42 UTC (permalink / raw) To: David Miller; +Cc: netdev, linux-kernel, Leech, Christopher > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Thursday, March 08, 2007 10:22 PM > To: Waskiewicz Jr, Peter P > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > Leech, Christopher > Subject: Re: [PATCH 0/2] NET: Multiple queue network device > support REPOST > > > You didn't address my correction the other day wherein I > clarified for you that my idea was not to store the queue mapping in > skb->priority but rather to shrink skb->priority to a u16 and > add a new u16 skb->queue_mapping or whatever field to store > the necessary information. > > You're just posting a set of patches using the same approach > again plus some bug fixes, so there is essentially nothing > new for anyone to review. > > Why ask for feedback if you fail to take any of it into consideration? > :-/ > This was taken into consideration, and I did reply that my concern for doing that could cause stale data in the skb if the queue mapping changed. If a qdisc was implemented that could change the band to queue mapping without having to reload the qdisc, the result could have skb's heading for the wrong queues until the old data was drained from the bands. An example: ->enqueue() - maps queue, commits to skb, adds to band netif_stop_queue(dev) - event is triggered that could cause a qdisc to remap bands to queues, drain hardware queues netif_wake_queue(dev) - reconfiguration is complete, resume transmission ->dequeue() - grab an skb enqueued prior to reconfiguration, read queue from skb, hard_start_xmit() to the wrong queue ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] NET: Multiple queue network device support REPOST 2007-03-09 6:42 ` Waskiewicz Jr, Peter P @ 2007-03-09 7:11 ` David Miller 2007-03-09 7:16 ` Waskiewicz Jr, Peter P 0 siblings, 1 reply; 6+ messages in thread From: David Miller @ 2007-03-09 7:11 UTC (permalink / raw) To: peter.p.waskiewicz.jr; +Cc: netdev, linux-kernel, christopher.leech From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com> Date: Thu, 8 Mar 2007 22:42:19 -0800 > This was taken into consideration, and I did reply that my concern for > doing that could cause stale data in the skb if the queue mapping > changed. This is not a problem. Since the ->enqueue function stores references to the SKBs, any change of the dev->qdisc has to flush those references somehow, and it is at that point that you can fixup the skb queue mappings. This happens via invoking the qdisc->ops->reset() method. ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 0/2] NET: Multiple queue network device support REPOST 2007-03-09 7:11 ` David Miller @ 2007-03-09 7:16 ` Waskiewicz Jr, Peter P 2007-03-09 7:26 ` David Miller 0 siblings, 1 reply; 6+ messages in thread From: Waskiewicz Jr, Peter P @ 2007-03-09 7:16 UTC (permalink / raw) To: David Miller; +Cc: netdev, linux-kernel, Leech, Christopher > This is not a problem. > > Since the ->enqueue function stores references to the SKBs, > any change of the dev->qdisc has to flush those references > somehow, and it is at that point that you can fixup the skb > queue mappings. > > This happens via invoking the qdisc->ops->reset() method. > Thanks Dave. It seems expensive to change all the skb's if this type of event occurs, but I suppose it is a corner case and can be tolerated. Please let me make this change and I'll resubmit. Also, the first patch set was RFC, and you were the only one to submit feedback to me. :-/ So I figured submitting as an official patch for feedback might get more attention. And to reiterate what Auke asked, what did happen to the patches? I see things getting through the netdev mailing list, but they're not showing up on www.spinics.net/lists/netdev. Was it something I did when sending, or did majordomo hiccup? Thanks, -PJ Waskiewicz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] NET: Multiple queue network device support REPOST 2007-03-09 7:16 ` Waskiewicz Jr, Peter P @ 2007-03-09 7:26 ` David Miller 0 siblings, 0 replies; 6+ messages in thread From: David Miller @ 2007-03-09 7:26 UTC (permalink / raw) To: peter.p.waskiewicz.jr; +Cc: netdev, linux-kernel, christopher.leech From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com> Date: Thu, 8 Mar 2007 23:16:58 -0800 > It seems expensive to change all the skb's if this type of > event occurs, The reset functions have to walk all the SKBs anyways. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] NET: Multiple queue network device support REPOST 2007-03-09 6:21 ` [PATCH 0/2] NET: Multiple queue network device support REPOST David Miller 2007-03-09 6:42 ` Waskiewicz Jr, Peter P @ 2007-03-09 6:45 ` Kok, Auke 1 sibling, 0 replies; 6+ messages in thread From: Kok, Auke @ 2007-03-09 6:45 UTC (permalink / raw) To: David Miller Cc: peter.p.waskiewicz.jr, netdev, linux-kernel, christopher.leech David Miller wrote: > You didn't address my correction the other day wherein I clarified > for you that my idea was not to store the queue mapping in > skb->priority but rather to shrink skb->priority to a u16 and > add a new u16 skb->queue_mapping or whatever field to store the > necessary information. > > You're just posting a set of patches using the same approach again > plus some bug fixes, so there is essentially nothing new for anyone to > review. > > Why ask for feedback if you fail to take any of it into consideration? > :-/ Where are the patches anyway? They didn't seem to make it either to netdev nor lkml! Auke ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-03-09 7:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1173420779298-git-send-email-peter.p.waskiewicz.jr@intel.com>
2007-03-09 6:21 ` [PATCH 0/2] NET: Multiple queue network device support REPOST David Miller
2007-03-09 6:42 ` Waskiewicz Jr, Peter P
2007-03-09 7:11 ` David Miller
2007-03-09 7:16 ` Waskiewicz Jr, Peter P
2007-03-09 7:26 ` David Miller
2007-03-09 6:45 ` Kok, Auke
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).