From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Linsys Contractor Mithlesh Thukral <mithlesh@netxen.com>
Cc: netdev@vger.kernel.org, amitkale@netxen.com, jeff@garzik.org,
netxenproj@linsyssoft.com, rob@netxen.com
Subject: Re: [PATCH 2/5] NetXen: Update the statistics counter for interrupts
Date: Fri, 09 Mar 2007 08:25:23 -0800 [thread overview]
Message-ID: <45F18A73.1080801@linux-foundation.org> (raw)
In-Reply-To: <200703090808.l2988A48011758@dut39.unminc.com>
Linsys Contractor Mithlesh Thukral wrote:
> NetXen: Update the statistics counter for interrupts which have occured.
>
> Signed-off-by: Mithlesh Thukral <mithlesh@netxen.com>
> ---
>
> drivers/net/netxen/netxen_nic_main.c | 1 +
> 1 files changed, 1 insertion(+)
>
> diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
> index bfeca9a..5fbf6b0 100644
> --- a/drivers/net/netxen/netxen_nic_main.c
> +++ b/drivers/net/netxen/netxen_nic_main.c
> @@ -1023,6 +1023,7 @@ netxen_handle_int(struct netxen_adapter
> u32 ret = 0;
>
> DPRINTK(INFO, "Entered handle ISR\n");
> + adapter->stats.ints++;
>
>
You may want to consider the cost of the additional cache miss.
Either don't bother with this stat, or go to per-cpu stats.
Plus isn't this already in the statistics kept for /proc/interrupts?
prev parent reply other threads:[~2007-03-09 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 8:08 [PATCH 2/5] NetXen: Update the statistics counter for interrupts Linsys Contractor Mithlesh Thukral
2007-03-09 16:25 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F18A73.1080801@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=amitkale@netxen.com \
--cc=jeff@garzik.org \
--cc=mithlesh@netxen.com \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).