* [PATCH 2/5] NetXen: Update the statistics counter for interrupts
@ 2007-03-09 8:08 Linsys Contractor Mithlesh Thukral
2007-03-09 16:25 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Linsys Contractor Mithlesh Thukral @ 2007-03-09 8:08 UTC (permalink / raw)
To: netdev; +Cc: amitkale, jeff, mithlesh, netxenproj, rob
NetXen: Update the statistics counter for interrupts which have occured.
Signed-off-by: Mithlesh Thukral <mithlesh@netxen.com>
---
drivers/net/netxen/netxen_nic_main.c | 1 +
1 files changed, 1 insertion(+)
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index bfeca9a..5fbf6b0 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1023,6 +1023,7 @@ netxen_handle_int(struct netxen_adapter
u32 ret = 0;
DPRINTK(INFO, "Entered handle ISR\n");
+ adapter->stats.ints++;
if (!(adapter->flags & NETXEN_NIC_MSI_ENABLED)) {
int count = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/5] NetXen: Update the statistics counter for interrupts
2007-03-09 8:08 [PATCH 2/5] NetXen: Update the statistics counter for interrupts Linsys Contractor Mithlesh Thukral
@ 2007-03-09 16:25 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2007-03-09 16:25 UTC (permalink / raw)
To: Linsys Contractor Mithlesh Thukral
Cc: netdev, amitkale, jeff, netxenproj, rob
Linsys Contractor Mithlesh Thukral wrote:
> NetXen: Update the statistics counter for interrupts which have occured.
>
> Signed-off-by: Mithlesh Thukral <mithlesh@netxen.com>
> ---
>
> drivers/net/netxen/netxen_nic_main.c | 1 +
> 1 files changed, 1 insertion(+)
>
> diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
> index bfeca9a..5fbf6b0 100644
> --- a/drivers/net/netxen/netxen_nic_main.c
> +++ b/drivers/net/netxen/netxen_nic_main.c
> @@ -1023,6 +1023,7 @@ netxen_handle_int(struct netxen_adapter
> u32 ret = 0;
>
> DPRINTK(INFO, "Entered handle ISR\n");
> + adapter->stats.ints++;
>
>
You may want to consider the cost of the additional cache miss.
Either don't bother with this stat, or go to per-cpu stats.
Plus isn't this already in the statistics kept for /proc/interrupts?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-09 16:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-09 8:08 [PATCH 2/5] NetXen: Update the statistics counter for interrupts Linsys Contractor Mithlesh Thukral
2007-03-09 16:25 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).