From: Jeff Garzik <jeff@garzik.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, john.ronciak@intel.com,
jesse.brandeburg@intel.com
Subject: Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq
Date: Fri, 09 Mar 2007 11:46:52 -0500 [thread overview]
Message-ID: <45F18F7C.3030801@garzik.org> (raw)
In-Reply-To: <20070306165721.27434.23796.stgit@localhost.localdomain>
Auke Kok wrote:
> From: Auke Kok <auke-jan.h.kok@intel.com>
>
> DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts
> after having called pci_request_irq. This obviously requires us to finish
> our software setup which assigns the irq handler before we request the
> irq.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
>
> drivers/net/e1000/e1000_main.c | 66 +++++++++++++++++++++++++++-------------
> 1 files changed, 45 insertions(+), 21 deletions(-)
All these do indeed look like fixes to me. But they look like low
priority fixes that would need some public testing behind them, and it's
pretty late in the 2.6.21-rc game.
I'll merge them into an e1000-fixes branch for now (and propagates
through #ALL to akpm's -mm). If replies to this email indicate we
really should push these upstream for 2.6.21-rc, it will be easy enough
to do so via #e1000-fixes.
Jeff
next prev parent reply other threads:[~2007-03-09 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 16:57 [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq Auke Kok
2007-03-06 16:57 ` [PATCH 2/3] e1000: FIX: firmware handover bits Auke Kok
2007-03-06 16:57 ` [PATCH 3/3] e1000: FIX: Stop raw interrupts disabled nag from RT Auke Kok
2007-03-09 16:46 ` Jeff Garzik [this message]
2007-03-09 17:11 ` [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq Kok, Auke
2007-03-09 17:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F18F7C.3030801@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).